From: "Bounine, Alexandre" <Alexandre.Bounine@idt.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] rapidio: apply RX/TX enable to active switch ports only
Date: Mon, 27 Aug 2012 13:01:00 +0000 [thread overview]
Message-ID: <8D983423E7EDF846BB3056827B8CC5D12E7C2C91@corpmail1.na.ads.idt.com> (raw)
In-Reply-To: <20120824140419.2b3a9623.akpm@linux-foundation.org>
On Friday, August 24, 2012 5:04 PM
Andrew Morton <akpm@linux-foundation.org>
>
> On Tue, 21 Aug 2012 10:23:55 -0400
> Alexandre Bounine <alexandre.bounine@idt.com> wrote:
>
>> Modify RIO enumeration to apply RX/TX enable operations only to
>> active switch ports. This will leave inactive ports in condition consistent
>> with their state.
>
> It's unclear (to me) what the effects of this are. Does it fix some
> user-visible malfunction? Or is it just some nice-to-have thing? Or
> what?
>
This patch was intended to keep inactive switch ports with inbound and
outbound packet transfers disabled to block unexpected packets during
hot insertion event. While it does not fix any visible malfunction it
was intended to prevent such events in future.
Since this patch was published it was brought to my attention that some
existing switches may require inbound and outbound ports enabled for
inactive ports as well (not spec compliant).
Therefore, please remove this patch from your tree.
>> This patch is applicable to kernel versions starting from v2.6.35.
>
> Is that a recommendation that such a backport be performed? If so,
> please provide the reasoning.
next prev parent reply other threads:[~2012-08-27 13:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 14:23 [PATCH] rapidio/tsi721: modify mport name assignment Alexandre Bounine
2012-08-21 14:23 ` [PATCH] rapidio: apply RX/TX enable to active switch ports only Alexandre Bounine
2012-08-24 21:04 ` Andrew Morton
2012-08-27 13:01 ` Bounine, Alexandre [this message]
2012-08-24 21:02 ` [PATCH] rapidio/tsi721: modify mport name assignment Andrew Morton
2012-08-27 14:49 ` Bounine, Alexandre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8D983423E7EDF846BB3056827B8CC5D12E7C2C91@corpmail1.na.ads.idt.com \
--to=alexandre.bounine@idt.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).