From: Paolo Valente <paolo.valente@linaro.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block <linux-block@vger.kernel.org>,
linux-kernel@vger.kernel.org, ulf.hansson@linaro.org,
broonie@kernel.org, linus.walleij@linaro.org,
bfq-iosched@googlegroups.com, oleksandr@natalenko.name
Subject: Re: [PATCH BUGFIX/IMPROVEMENT 0/2] block, bfq: two pending patches
Date: Thu, 18 Jan 2018 09:25:43 +0100 [thread overview]
Message-ID: <8EB4BACE-3D6D-4EB7-844E-45092AC7644B@linaro.org> (raw)
In-Reply-To: <20180113110518.2519-1-paolo.valente@linaro.org>
> Il giorno 13 gen 2018, alle ore 12:05, Paolo Valente <paolo.valente@linaro.org> ha scritto:
>
> Hi Jens,
> here are again the two pending patches you asked me to resend [1]. One
> of them, fixing read-starvation problems, was accompanied by a cover
> letter. I'm pasting the content of that cover letter below.
>
> The patch addresses (serious) starvation problems caused by
> request-tag exhaustion, as explained in more detail in the commit
> message. I started from the solution in the function
> kyber_limit_depth, but then I had to define more articulate limits, to
> counter starvation also in cases not covered in kyber_limit_depth.
> If this solution proves to be effective, I'm willing to port it
> somehow to the other schedulers.
>
Hi Jens,
have had to time to check these patches? Sorry for pushing, but I
guess 4.16 is getting closer, and these patches are performance
critical; especially the first, which solves a starvation problem.
Thanks,
Paolo
> Thanks,
> Paolo
>
> [1] https://www.spinics.net/lists/linux-block/msg21586.html
>
> Paolo Valente (2):
> block, bfq: limit tags for writes and async I/O
> block, bfq: limit sectors served with interactive weight raising
>
> block/bfq-iosched.c | 158 +++++++++++++++++++++++++++++++++++++++++++++++++---
> block/bfq-iosched.h | 17 ++++++
> block/bfq-wf2q.c | 3 +
> 3 files changed, 169 insertions(+), 9 deletions(-)
>
> --
> 2.15.1
next prev parent reply other threads:[~2018-01-18 8:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-13 11:05 [PATCH BUGFIX/IMPROVEMENT 0/2] block, bfq: two pending patches Paolo Valente
2018-01-13 11:05 ` [PATCH BUGFIX/IMPROVEMENT 1/2] block, bfq: limit tags for writes and async I/O Paolo Valente
2018-01-13 11:05 ` [PATCH BUGFIX/IMPROVEMENT 2/2] block, bfq: limit sectors served with interactive weight raising Paolo Valente
2018-01-13 13:02 ` [PATCH BUGFIX/IMPROVEMENT 0/2] block, bfq: two pending patches Oleksandr Natalenko
2018-01-18 8:25 ` Paolo Valente [this message]
2018-01-18 15:23 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8EB4BACE-3D6D-4EB7-844E-45092AC7644B@linaro.org \
--to=paolo.valente@linaro.org \
--cc=axboe@kernel.dk \
--cc=bfq-iosched@googlegroups.com \
--cc=broonie@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr@natalenko.name \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).