From: Paul Cercueil <paul@crapouillou.net>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Kees Cook <keescook@chromium.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Andrzej Hajda <a.hajda@samsung.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Robert Foss <robert.foss@linaro.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Ezequiel Garcia <ezequiel@collabora.com>,
Harry Wentland <harry.wentland@amd.com>,
Sam Ravnborg <sam@ravnborg.org>,
Maxime Ripard <maxime@cerno.tech>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
devicetree@vger.kernel.org, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org,
Paul Boddie <paul@boddie.org.uk>, Jonas Karlman <jonas@kwiboo.se>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 8/8] [RFC] drm/ingenic: convert to component framework for jz4780 hdmi
Date: Thu, 05 Aug 2021 18:17:32 +0200 [thread overview]
Message-ID: <8XJDXQ.X70C5WOD0QB7@crapouillou.net> (raw)
In-Reply-To: <BDF501D1-BA1D-4866-8EAF-3862F6CEC6F4@goldelico.com>
Hi Nikolaus and Laurent,
Le jeu., août 5 2021 at 18:07:20 +0200, H. Nikolaus Schaller
<hns@goldelico.com> a écrit :
> Hi Laurent,
>
>> Am 05.08.2021 um 17:04 schrieb Laurent Pinchart
>> <laurent.pinchart@ideasonboard.com>:
>>
>> Hi Nikolaus,
>>
>> Thank you for the patch.
>>
>> On Thu, Aug 05, 2021 at 04:07:57PM +0200, H. Nikolaus Schaller
>> wrote:
>>> This patch attempts to convert the ingenic-dw-hdmi driver
>>> into a version that uses the component framework.
>>
>> Why ? What problem would this solve ?
>
> Well, it was suggested in a v1 we did post several months ago. I have
> not
> looked up by whom and do not exactly remember the reasons.
>
> We now simply thought that it is common style since dome dw-hdmi
> drivers
> make use of it but some others don't. And we got it working without.
>
> If it is not needed/requested by anyone, we can drop it from v3 (or
> add later).
I don't remember exactly TBH - the only reason to use a component is to
have access to the main driver's "drm_device" structure. The IPU needs
it for instance, to register planes; but I don't think this HDMI driver
needs it as it registers a bridge.
Cheers,
-Paul
next prev parent reply other threads:[~2021-08-05 16:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 14:07 [PATCH v2 0/8] MIPS: jz4780 HDMI H. Nikolaus Schaller
2021-08-05 14:07 ` [PATCH v2 1/8] drm/bridge: synopsis: Add mode_fixup and bridge timings support H. Nikolaus Schaller
2021-08-05 14:32 ` Robert Foss
2021-08-05 14:45 ` H. Nikolaus Schaller
2021-08-08 4:50 ` H. Nikolaus Schaller
2021-08-05 14:07 ` [PATCH v2 2/8] drm/ingenic: Add jz4780 Synopsys HDMI driver H. Nikolaus Schaller
2021-08-05 14:07 ` [PATCH v2 3/8] drm/ingenic: Add support for JZ4780 and HDMI output H. Nikolaus Schaller
2021-08-05 15:22 ` Paul Cercueil
2021-08-05 16:01 ` H. Nikolaus Schaller
2021-08-08 5:04 ` H. Nikolaus Schaller
2021-08-05 14:07 ` [PATCH v2 4/8] dt-bindings: display: Add ingenic-jz4780-hdmi DT Schema H. Nikolaus Schaller
2021-08-05 14:07 ` [PATCH v2 5/8] MIPS: DTS: jz4780: account for Synopsys HDMI driver and LCD controller H. Nikolaus Schaller
2021-08-05 14:07 ` [PATCH v2 6/8] MIPS: DTS: CI20: add HDMI setup H. Nikolaus Schaller
2021-08-05 14:07 ` [PATCH v2 7/8] MIPS: CI20: defconfig: configure for DRM_DW_HDMI_JZ4780 H. Nikolaus Schaller
2021-08-05 14:07 ` [PATCH v2 8/8] [RFC] drm/ingenic: convert to component framework for jz4780 hdmi H. Nikolaus Schaller
2021-08-05 15:04 ` Laurent Pinchart
2021-08-05 16:07 ` H. Nikolaus Schaller
2021-08-05 16:17 ` Paul Cercueil [this message]
2021-08-05 16:22 ` H. Nikolaus Schaller
2021-08-10 9:31 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8XJDXQ.X70C5WOD0QB7@crapouillou.net \
--to=paul@crapouillou.net \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=ebiederm@xmission.com \
--cc=ezequiel@collabora.com \
--cc=geert+renesas@glider.be \
--cc=harry.wentland@amd.com \
--cc=hns@goldelico.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=keescook@chromium.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime@cerno.tech \
--cc=miquel.raynal@bootlin.com \
--cc=narmstrong@baylibre.com \
--cc=paul@boddie.org.uk \
--cc=robert.foss@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).