From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31C6BC4727C for ; Tue, 22 Sep 2020 19:46:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B584E20888 for ; Tue, 22 Sep 2020 19:46:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="wDZyCv7y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726682AbgIVTqe (ORCPT ); Tue, 22 Sep 2020 15:46:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726448AbgIVTqe (ORCPT ); Tue, 22 Sep 2020 15:46:34 -0400 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B46AC061755; Tue, 22 Sep 2020 12:46:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=vpSLW0AXxHiTl89BtY+FVX4uAPscibs5ZsZA2qiROfY=; b=wDZyCv7yvGG2GnkpZaURO0RTZS E6UlFGA+vTLWqu85rvy6v9LuN6InuVbFG9d1v3qiAYZxWelZrMS20Fbb1riEL1AeOh52DdFQ6+qcR zNw0H26caKWFZ6AbewC3Oat/38yjDxd1G3x648tngQwEy0mU3jwPWsc7+ri+fGfzvjSkzJICxm8gP kpVUL8WQ0XigraXMH3DeGlBArarM1Z6aRgyIo1Y0/YmZvZdyLE0y2kceU0/jMAsps4Rlnrqh2dTqp zTdrjItl2pwUl8mbVINEbTjZs2/MpvJ/pqZpEdAvrnwCu8Lx17TCew3QRt6tmX2wmKZgv/JSwuA9t BRUQq3mA==; Received: from [2601:1c0:6280:3f0:897c:6038:c71d:ecac] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKoFD-0005mC-9i; Tue, 22 Sep 2020 19:46:32 +0000 Subject: Re: [PATCH 0/1] Add explicit error for missing CONFIG_ASN1 To: James Bottomley , linux-kbuild@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Masahiro Yamada References: <20200922155341.17906-1-James.Bottomley@HansenPartnership.com> <260b4b85d714df822da259554ef8cc2873f3096f.camel@HansenPartnership.com> <36232f66-58b1-77a8-91a3-f9d3428fffb5@infradead.org> <15cc1edce12357799ae3caea3b89a3aad3a3bd07.camel@HansenPartnership.com> From: Randy Dunlap Message-ID: <8a346ff9-21a4-db8b-1636-b9b2472b5b87@infradead.org> Date: Tue, 22 Sep 2020 12:46:27 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <15cc1edce12357799ae3caea3b89a3aad3a3bd07.camel@HansenPartnership.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/22/20 12:44 PM, James Bottomley wrote: > On Tue, 2020-09-22 at 12:38 -0700, Randy Dunlap wrote: >> On 9/22/20 12:19 PM, James Bottomley wrote: >>> On Tue, 2020-09-22 at 11:54 -0700, Randy Dunlap wrote: >>>> On 9/22/20 8:53 AM, James Bottomley wrote: >>>>> I recently ran into this as an error from 0day. On x86 it's >>>>> pretty >>>>> much impossible to build a configuration where CONFIG_ASN1 >>>>> isn't >>>>> set, so you rarely notice a problem using the ASN.1 compiler >>>>> because something else has selected it. However, this compiler >>>>> is >>>>> never built if CONFIG_ASN1 isn't set and the error you get from >>>>> kbuild is particularly unhelpful: >>>>> >>>>> make[4]: *** No rule to make target 'security/keys/trusted- >>>>> keys/tpm2key.asn1.o', needed by 'security/keys/trusted- >>>>> keys/built- >>>>> in.a'. >>>>> make[4]: *** [scripts/Makefile.build:283: >>>>> security/keys/trusted- >>>>> keys/trusted_tpm2.o] Error 1 >>>>> make[4]: Target '__build' not remade because of errors. >>>>> >>>>> This patch changes the above error to the much easier to >>>>> diagnose: >>>>> >>>>> scripts/Makefile.build:387: *** CONFIG_ASN1 must be defined >>>>> for >>>>> the asn1_compiler. Stop. >>>>> make[3]: *** [scripts/Makefile.build:505: >>>>> security/keys/trusted- >>>>> keys] Error 2 >>>>> >>>>> James >>>>> >>>>> --- >>>>> >>>>> James Bottomley (1): >>>>> Makefile.build: Add an explicit error for missing ASN.1 >>>>> compiler >>>>> >>>>> scripts/Makefile.build | 5 +++++ >>>>> 1 file changed, 5 insertions(+) >>>> >>>> Is there a missing >>>> select ASN1 >>>> somewhere? >>> >>> You mean in the build used to produce the errors above? Yes, so >>> the >>> patch is to make the problem more explicit. >> >> I appreciate that the message can be improved, but it seems possible >> that some Kconfig could also be improved. > > I don't really see how. To find the problem you have to identify a > conditional build in the Makefile that requires the asn1 compiler but > for which the config option doesn't have a select ASN1. We don't > currently preserve the "what selected this symbol" information in > kconfig, which is what we'd need. Well, if you have a failing .config file, I would be glad to take a look at it... -- ~Randy