From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
linux-gpio@vger.kernel.org
Subject: [PATCH 1/3] misc: microchip: pci1xxxx: Do not disable the pci device twice in gp_aux_bus_remove()
Date: Sun, 18 Sep 2022 08:27:24 +0200 [thread overview]
Message-ID: <8a3a385b3ae15ee7497469ec3250302b626a018b.1663482259.git.christophe.jaillet@wanadoo.fr> (raw)
In-Reply-To: <cover.1663482259.git.christophe.jaillet@wanadoo.fr>
gp_aux_bus_probe() uses pcim_enable_device(), so there is no point in
calling pci_disable_device() explicitly in the remove function.
Fixes: 393fc2f5948f ("misc: microchip: pci1xxxx: load auxiliary bus driver for the PIO function in the multi-function endpoint of pci1xxxx device.")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c b/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c
index edff3ee73f6f..6c4f8384aa09 100644
--- a/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c
+++ b/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c
@@ -139,7 +139,6 @@ static void gp_aux_bus_remove(struct pci_dev *pdev)
auxiliary_device_delete(&aux_bus->aux_device_wrapper[1]->aux_dev);
auxiliary_device_uninit(&aux_bus->aux_device_wrapper[1]->aux_dev);
kfree(aux_bus);
- pci_disable_device(pdev);
}
static const struct pci_device_id pci1xxxx_tbl[] = {
--
2.34.1
next prev parent reply other threads:[~2022-09-18 6:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-18 6:27 [PATCH 0/3] misc: microchip: pci1xxxx: Fix the error handling path of gp_aux_bus_probe() Christophe JAILLET
2022-09-18 6:27 ` Christophe JAILLET [this message]
2022-09-18 6:27 ` [PATCH 2/3] misc: microchip: pci1xxxx: Fix a memory leak in the error handling " Christophe JAILLET
2022-09-18 6:27 ` [PATCH 3/3] misc: microchip: pci1xxxx: Fix the error handling paths " Christophe JAILLET
2022-09-18 8:03 ` kernel test robot
2022-09-18 9:25 ` Christophe JAILLET
2022-09-19 17:47 ` Kumaravel.Thiagarajan
2022-09-21 22:59 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a3a385b3ae15ee7497469ec3250302b626a018b.1663482259.git.christophe.jaillet@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kumaravel.thiagarajan@microchip.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).