From: Florian Fainelli <f.fainelli@gmail.com>
To: Masahiko Kimoto <masahiko.kimoto@cybertrust.co.jp>,
Fugang Duan <fugang.duan@nxp.com>, Andrew Lunn <andrew@lunn.ch>,
netdev@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Hiraku Toyooka <hiraku.toyooka@cybertrust.co.jp>
Subject: Re: [RFC PATCH 0/1] net: phy: skip autoneg of ethernet(fec) on network boot
Date: Fri, 6 Jul 2018 11:41:23 -0700 [thread overview]
Message-ID: <8a437ead-5ded-57c4-c44f-95986442d626@gmail.com> (raw)
In-Reply-To: <1530857230-31124-1-git-send-email-masahiko.kimoto@cybertrust.co.jp>
On 07/05/2018 11:07 PM, Masahiko Kimoto wrote:
> Hello,
>
> This patch introduces auto negotiation skipping for Ethernet.
> It is useful to shorten boot time on network boot like the following
> environment;
>
> - target board is NXP i.MX6.
> - NIC is fec.
> - using u-boot as boot loader.
> - boot from kernel and initramfs obtained via TFTP.
> - mount remote file system and switch root to that.
> - thus all file system is on network.
>
> In this case, u-boot and kernel initialize NIC three times,
> once in boot loader, once in device attach and once more in phy attach.
> Each causes link auto negotiation and wait several seconds.
> However link state is stable after reset by boot loader, therefore we
> can skip hardware re-initialization of NIC in kernel.
>
> The patch skips link down in Ethernet(i.MX's fec) driver and initialization
> in PHY layer if kernel option 'anegskip' is supplied.
>
> By this patch boot time becomes 3secs shorter.
>
> I think current patch is dirty hack, because;
> - modification is split into PHY and Ethernet driver.
> - in the case of two or more Ethernet I/F exist, currently there is
> no way to specify whith I/F skips autonego.
>
> I would like to implement such skpping auto negotiation feature in generic
> framework. How should we implement these requirements?
I completely acknowledge and support the use case, but your
implementation is definitively not the way to go. In my experience the
problem is usually that there may be a disagreement on the
Pause/Asym_Pause advertisement bits and that alone is responsible for
triggering a re-negotiation. Can yo check if that is the case here?
Thank you
--
Florian
next parent reply other threads:[~2018-07-06 18:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1530857230-31124-1-git-send-email-masahiko.kimoto@cybertrust.co.jp>
2018-07-06 18:41 ` Florian Fainelli [this message]
2018-07-09 9:29 ` [RFC PATCH 0/1] net: phy: skip autoneg of ethernet(fec) on network boot Masahiko KIMOTO
2018-07-09 14:41 ` Andrew Lunn
2018-07-10 1:52 ` Masahiko KIMOTO
2018-07-17 1:47 ` Masahiko KIMOTO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a437ead-5ded-57c4-c44f-95986442d626@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=fugang.duan@nxp.com \
--cc=hiraku.toyooka@cybertrust.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiko.kimoto@cybertrust.co.jp \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).