From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Randy Dunlap <rdunlap@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
moderated for non-subscribers <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH -next] ASoC: ti: fix SND_SOC_J721E_EVM warnings & errors
Date: Wed, 22 Jul 2020 17:58:17 +0300 [thread overview]
Message-ID: <8a5baa38-e5a9-ab82-d186-9939733e4d7e@ti.com> (raw)
In-Reply-To: <e74c690c-c7f8-fd42-e461-4f33571df4ef@infradead.org>
Hi Randy,
On 20/07/2020 21.32, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> SND_SOC_J721E_EVM should not select SND_SOC_PCM3168A_I2C when I2C
> is not enabled. That causes build errors, so make this driver's
> symbol depend on I2C.
Thank you for the fix!
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> WARNING: unmet direct dependencies detected for SND_SOC_PCM3168A_I2C
> Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && I2C [=n]
> Selected by [m]:
> - SND_SOC_J721E_EVM [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && (DMA_OMAP [=y] || TI_EDMA [=m] || TI_K3_UDMA [=n] || COMPILE_TEST [=y]) && (ARCH_K3_J721E_SOC [=n] || COMPILE_TEST [=y])
>
> ../sound/soc/codecs/pcm3168a-i2c.c:59:1: warning: data definition has no type or storage class
> module_i2c_driver(pcm3168a_i2c_driver);
> ^~~~~~~~~~~~~~~~~
> ../sound/soc/codecs/pcm3168a-i2c.c:59:1: error: type defaults to ‘int’ in declaration of ‘module_i2c_driver’ [-Werror=implicit-int]
> ../sound/soc/codecs/pcm3168a-i2c.c:59:1: warning: parameter names (without types) in function declaration
> ../sound/soc/codecs/pcm3168a-i2c.c:49:26: warning: ‘pcm3168a_i2c_driver’ defined but not used [-Wunused-variable]
> static struct i2c_driver pcm3168a_i2c_driver = {
> ^~~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
>
>
> Fixes: 6748d0559059 ("ASoC: ti: Add custom machine driver for j721e EVM (CPB and IVI)")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Cc: Mark Brown <broonie@kernel.org>
> ---
> sound/soc/ti/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20200720.orig/sound/soc/ti/Kconfig
> +++ linux-next-20200720/sound/soc/ti/Kconfig
> @@ -222,6 +222,7 @@ config SND_SOC_DM365_VOICE_CODEC_MODULE
> config SND_SOC_J721E_EVM
> tristate "SoC Audio support for j721e EVM"
> depends on ARCH_K3_J721E_SOC || COMPILE_TEST
> + depends on I2C
> select SND_SOC_PCM3168A_I2C
> select SND_SOC_DAVINCI_MCASP
> help
>
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2020-07-22 14:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 18:32 [PATCH -next] ASoC: ti: fix SND_SOC_J721E_EVM warnings & errors Randy Dunlap
2020-07-22 14:58 ` Peter Ujfalusi [this message]
2020-07-23 20:19 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a5baa38-e5a9-ab82-d186-9939733e4d7e@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).