From: robin <robin@protonic.nl>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Rob Herring <robh+dt@kernel.org>, Miguel Ojeda <ojeda@kernel.org>,
Paul Burton <paulburton@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devicetree@vger.kernel.org, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/17] auxdisplay: Extract character line display core support
Date: Tue, 23 Mar 2021 09:18:11 +0100 [thread overview]
Message-ID: <8a5e3e480022990f0889864d0ace56a0@protonic.nl> (raw)
In-Reply-To: <20210322144848.1065067-7-geert@linux-m68k.org>
On 2021-03-22 15:48, Geert Uytterhoeven wrote:
> Extract the character line display core support from the simple ASCII
> LCD driver for the MIPS Boston, Malta & SEAD3 development boards into
> its own subdriver, so it can be reused for other displays.
>
> Note that this moves the "message" device attribute in sysfs in a
> "linedisp.N" subdirectory.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> Changes to img-ascii-lcd.c are untested due to lack of hardware.
> ---
> drivers/auxdisplay/Kconfig | 8 +
> drivers/auxdisplay/Makefile | 1 +
> drivers/auxdisplay/img-ascii-lcd.c | 198 +++----------------------
> drivers/auxdisplay/line-display.c | 231 +++++++++++++++++++++++++++++
> drivers/auxdisplay/line-display.h | 43 ++++++
> 5 files changed, 304 insertions(+), 177 deletions(-)
> create mode 100644 drivers/auxdisplay/line-display.c
> create mode 100644 drivers/auxdisplay/line-display.h
>
> diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
> index 1509cb74705a30ad..42fc7b155de09dbc 100644
> --- a/drivers/auxdisplay/Kconfig
> +++ b/drivers/auxdisplay/Kconfig
> @@ -25,6 +25,12 @@ config CHARLCD
> This is some character LCD core interface that multiple drivers can
> use.
>
> +config LINEDISP
> + tristate "Character line display core support" if COMPILE_TEST
> + help
> + This is the core support for single-line character displays, to be
> + selected by drivers that use it.
> +
> config HD44780_COMMON
> tristate "Common functions for HD44780 (and compatibles) LCD
> displays" if COMPILE_TEST
> select CHARLCD
> @@ -155,6 +161,7 @@ config IMG_ASCII_LCD
> depends on HAS_IOMEM
> default y if MIPS_MALTA
> select MFD_SYSCON
> + select LINEDISP
> help
> Enable this to support the simple ASCII LCD displays found on
> development boards such as the MIPS Boston, MIPS Malta & MIPS SEAD3
> @@ -169,6 +176,7 @@ config HT16K33
> select FB_SYS_IMAGEBLIT
> select INPUT_MATRIXKMAP
> select FB_BACKLIGHT
> + select LINEDISP
At this point in your patch stack it's not used by the ht16k33 driver. I
think it
would be nicer to add this dependency when the code actually starts
depending on it.
So that when this patch stack gets applied partially or not in one go
the chunks
would be independent.
next prev parent reply other threads:[~2021-03-23 8:19 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 14:48 [PATCH 00/17] auxdisplay: ht16k33: Add character display support Geert Uytterhoeven
2021-03-22 14:48 ` [PATCH 01/17] uapi: Add <linux/map_to_14segment.h> Geert Uytterhoeven
2021-03-22 17:05 ` Miguel Ojeda
2021-03-22 17:51 ` Geert Uytterhoeven
2021-03-22 14:48 ` [PATCH 02/17] dt-bindings: auxdisplay: ht16k33: Document Adafruit segment displays Geert Uytterhoeven
2021-03-22 17:38 ` Rob Herring
2021-03-23 9:12 ` robin
2021-05-18 14:35 ` Geert Uytterhoeven
2021-05-19 10:37 ` Robin van der Gracht
2021-05-19 11:02 ` Geert Uytterhoeven
2021-03-22 14:48 ` [PATCH 03/17] auxdisplay: img-ascii-lcd: Fix lock-up when displaying empty string Geert Uytterhoeven
2021-03-22 14:48 ` [PATCH 04/17] auxdisplay: img-ascii-lcd: Add helper variable dev Geert Uytterhoeven
2021-03-22 16:59 ` Miguel Ojeda
2021-03-22 17:53 ` Geert Uytterhoeven
2021-03-22 14:48 ` [PATCH 05/17] auxdisplay: img-ascii-lcd: Convert device attribute to sysfs_emit() Geert Uytterhoeven
2021-03-22 14:48 ` [PATCH 06/17] auxdisplay: Extract character line display core support Geert Uytterhoeven
2021-03-23 8:18 ` robin [this message]
2021-03-23 8:52 ` Geert Uytterhoeven
2021-03-22 14:48 ` [PATCH 07/17] auxdisplay: linedisp: Use kmemdup_nul() helper Geert Uytterhoeven
2021-03-22 14:48 ` [PATCH 08/17] auxdisplay: linedisp: Add support for changing scroll rate Geert Uytterhoeven
2021-03-22 14:48 ` [PATCH 09/17] auxdisplay: ht16k33: Use HT16K33_FB_SIZE in ht16k33_initialize() Geert Uytterhoeven
2021-03-23 7:59 ` robin
2021-03-22 14:48 ` [PATCH 10/17] auxdisplay: ht16k33: Remove unneeded error check in keypad probe() Geert Uytterhoeven
2021-03-23 8:08 ` robin
2021-03-22 14:48 ` [PATCH 11/17] auxdisplay: ht16k33: Convert to simple i2c probe function Geert Uytterhoeven
2021-03-23 8:31 ` robin
2021-03-22 14:48 ` [PATCH 12/17] auxdisplay: ht16k33: Add helper variable dev Geert Uytterhoeven
2021-03-23 8:57 ` robin
2021-03-22 14:48 ` [PATCH 13/17] auxdisplay: ht16k33: Move delayed work Geert Uytterhoeven
2021-03-22 14:48 ` [PATCH 14/17] auxdisplay: ht16k33: Extract ht16k33_brightness_set() Geert Uytterhoeven
2021-03-22 14:48 ` [PATCH 15/17] auxdisplay: ht16k33: Extract frame buffer probing Geert Uytterhoeven
2021-03-22 14:48 ` [PATCH 16/17] auxdisplay: ht16k33: Add support for segment displays Geert Uytterhoeven
2021-03-29 7:08 ` Robin van der Gracht
2021-03-29 7:15 ` Geert Uytterhoeven
2021-03-29 7:30 ` Robin van der Gracht
2021-03-22 14:48 ` [PATCH 17/17] auxdisplay: ht16k33: Add segment display LED support Geert Uytterhoeven
2021-03-23 10:08 ` Robin van der Gracht
2021-03-23 12:32 ` Geert Uytterhoeven
2021-03-23 20:40 ` Pavel Machek
2021-03-24 8:31 ` Geert Uytterhoeven
2021-03-27 22:19 ` Pavel Machek
2021-06-25 12:39 ` Geert Uytterhoeven
2021-03-22 17:03 ` [PATCH 00/17] auxdisplay: ht16k33: Add character display support Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a5e3e480022990f0889864d0ace56a0@protonic.nl \
--to=robin@protonic.nl \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=paulburton@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).