From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753827AbcLKSDi (ORCPT <rfc822;w@1wt.eu>);
        Sun, 11 Dec 2016 13:03:38 -0500
Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:45402 "EHLO
        mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1753574AbcLKSDh (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 11 Dec 2016 13:03:37 -0500
Subject: Re: [PATCH v2 1/1] lockd: Change nsm_use_hostnames from bool to u32
To: Jia He <hejianet@gmail.com>, linux-nfs@vger.kernel.org
References: <1481470609-31488-1-git-send-email-hejianet@gmail.com>
 <1481470609-31488-2-git-send-email-hejianet@gmail.com>
 <819a5924-6fd4-adce-c03f-2a83c99d0a27@linux.vnet.ibm.com>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
        Jeff Layton <jlayton@poochiereds.net>,
        Trond Myklebust <trond.myklebust@primarydata.com>,
        Anna Schumaker <anna.schumaker@netapp.com>,
        linux-kernel@vger.kernel.org
From: Pan Xinhui <xinhui@linux.vnet.ibm.com>
Date: Mon, 12 Dec 2016 02:03:27 +0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0)
 Gecko/20100101 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <819a5924-6fd4-adce-c03f-2a83c99d0a27@linux.vnet.ibm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
X-TM-AS-MML: disable
X-Content-Scanned: Fidelis XPS MAILER
x-cbid: 16121118-0032-0000-0000-000001A4D4B4
X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused
x-cbparentid: 16121118-0033-0000-0000-00001148E155
Message-Id: <8a609db8-b715-4aad-913e-62fe8f6ec45d@linux.vnet.ibm.com>
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-11_13:,,
 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0
 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam
 adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000
 definitions=main-1612110283
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



在 2016/12/12 01:43, Pan Xinhui 写道:
>
> hi, jia
>     nice catch!
> However I think we should fix it totally.
> This is because do_proc_dointvec_conv() try to get a int value from a bool *.
>
> something like below might help. pls. ignore the code style and this is tested :)
									_untested_.