From: Yisheng Xie <xieyisheng1@huawei.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 27/33] sched/debug: use match_string() helper
Date: Tue, 22 May 2018 20:10:37 +0800 [thread overview]
Message-ID: <8a7108ce-a109-a1b5-ace7-38a189d2352d@huawei.com> (raw)
In-Reply-To: <CAHp75VcTpAkMeKa0YXpp91WooVPs5X7jPGk0w2ruitp4siKLVw@mail.gmail.com>
Hi Andy,
On 2018/5/22 6:13, Andy Shevchenko wrote:
> On Mon, May 21, 2018 at 2:58 PM, Yisheng Xie <xieyisheng1@huawei.com> wrote:
>> match_string() returns the index of an array for a matching string,
>> which can be used intead of open coded variant.
>>
>> Cc: Ingo Molnar <mingo@redhat.com>
>> Cc: Peter Zijlstra <peterz@infradead.org>
>> Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
>> ---
>> kernel/sched/debug.c | 20 +++++++++-----------
>> 1 file changed, 9 insertions(+), 11 deletions(-)
>>
>> diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
>> index 15b10e2..9e34499 100644
>> --- a/kernel/sched/debug.c
>> +++ b/kernel/sched/debug.c
>> @@ -111,16 +111,14 @@ static int sched_feat_set(char *cmp)
>> cmp += 3;
>> }
>>
>> - for (i = 0; i < __SCHED_FEAT_NR; i++) {
>> - if (strcmp(cmp, sched_feat_names[i]) == 0) {
>> - if (neg) {
>> - sysctl_sched_features &= ~(1UL << i);
>> - sched_feat_disable(i);
>> - } else {
>> - sysctl_sched_features |= (1UL << i);
>> - sched_feat_enable(i);
>> - }
>> - break;
>> + i = match_string(sched_feat_names, __SCHED_FEAT_NR, cmp);
>
>> + if (i >= 0) {
>
> Why not
>
> if (i < 0)
> return i;
if i >=0 it will also return i. so need return i just if (i < 0), right ?
>
> ?
>
>> + if (neg) {
>> + sysctl_sched_features &= ~(1UL << i);
>> + sched_feat_disable(i);
>> + } else {
>> + sysctl_sched_features |= (1UL << i);
>> + sched_feat_enable(i);
>> }
>> }
>>
>> @@ -150,7 +148,7 @@ static int sched_feat_set(char *cmp)
>> inode_lock(inode);
>> i = sched_feat_set(cmp);
>> inode_unlock(inode);
>
>> - if (i == __SCHED_FEAT_NR)
>> + if (i < 0)
>> return -EINVAL;
>
> Now it would be
>
> if (i < 0)
> return i;
Right, will change it in next version
Thanks
Yisheng Xie
>
next prev parent reply other threads:[~2018-05-22 12:12 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 11:57 [PATCH 00/33] use match_string() helper Yisheng Xie
2018-05-21 11:57 ` [PATCH 01/33] usb: phy: " Yisheng Xie
2018-05-21 22:20 ` Andy Shevchenko
2018-05-22 10:02 ` Greg Kroah-Hartman
2018-05-22 11:12 ` Yisheng Xie
2018-05-21 11:57 ` [PATCH 02/33] mfd: omap-usb-host: " Yisheng Xie
2018-05-21 17:41 ` Tony Lindgren
2018-06-04 6:15 ` Lee Jones
2018-05-21 11:57 ` [PATCH 03/33] Staging: gdm724x: " Yisheng Xie
2018-05-21 21:35 ` Andy Shevchenko
2018-05-21 11:57 ` [PATCH 04/33] gpiolib-of: " Yisheng Xie
2018-05-21 21:36 ` Andy Shevchenko
2018-05-21 11:57 ` [PATCH 05/33] cxgb4: " Yisheng Xie
2018-05-21 21:39 ` Andy Shevchenko
2018-05-22 0:55 ` Yisheng Xie
2018-05-21 11:57 ` [PATCH 06/33] hp100: " Yisheng Xie
2018-05-21 11:57 ` [PATCH 07/33] iwlwifi: mvm: " Yisheng Xie
2018-05-21 20:12 ` Luca Coelho
2018-05-21 21:43 ` Andy Shevchenko
2018-05-22 3:30 ` Yisheng Xie
2018-05-22 20:41 ` Andy Shevchenko
2018-05-21 11:57 ` [PATCH 08/33] vfio: " Yisheng Xie
2018-05-25 20:55 ` Alex Williamson
2018-05-21 11:57 ` [PATCH 09/33] phy: tegra: " Yisheng Xie
2018-05-21 21:45 ` Andy Shevchenko
2018-05-21 11:57 ` [PATCH 10/33] pata_hpt37x: " Yisheng Xie
2018-05-21 21:46 ` Andy Shevchenko
2018-05-21 11:57 ` [PATCH 11/33] bus: fsl-mc: " Yisheng Xie
2018-05-21 11:57 ` [PATCH 12/33] clk: bcm2835: " Yisheng Xie
2018-05-21 17:48 ` Eric Anholt
2018-05-21 21:50 ` Andy Shevchenko
2018-05-22 3:42 ` Yisheng Xie
2018-05-21 11:57 ` [PATCH 13/33] clk: rockchip: " Yisheng Xie
2018-05-22 13:56 ` Heiko Stuebner
2018-05-21 11:57 ` [PATCH 14/33] clk: " Yisheng Xie
2018-05-21 21:53 ` Andy Shevchenko
2018-05-21 11:57 ` [PATCH 15/33] cpufreq: intel_pstate: " Yisheng Xie
2018-05-21 11:57 ` [PATCH 16/33] mmc: sdhci-xenon: " Yisheng Xie
2018-05-24 7:58 ` Adrian Hunter
2018-05-28 11:27 ` Ulf Hansson
2018-05-21 11:57 ` [PATCH 17/33] pinctrl: armada-37xx: " Yisheng Xie
2018-05-21 21:55 ` Andy Shevchenko
2018-05-21 11:57 ` [PATCH 18/33] power: supply: " Yisheng Xie
2018-05-21 21:58 ` Andy Shevchenko
2018-05-22 16:16 ` Sebastian Reichel
2018-05-21 11:57 ` [PATCH 19/33] thermal: db8500: " Yisheng Xie
2018-05-21 22:00 ` Andy Shevchenko
2018-05-23 7:47 ` Yisheng Xie
2018-06-05 16:14 ` Andy Shevchenko
2018-05-21 11:57 ` [PATCH 20/33] video: fbdev: pxafb: " Yisheng Xie
2018-05-21 22:01 ` Andy Shevchenko
2018-05-21 11:57 ` [PATCH 21/33] drm/nouveau: " Yisheng Xie
2018-05-21 22:03 ` Andy Shevchenko
2018-05-21 11:57 ` [PATCH 22/33] drm/i915: " Yisheng Xie
2018-05-21 22:04 ` Andy Shevchenko
2018-05-22 8:36 ` Jani Nikula
2018-05-22 9:22 ` Yisheng Xie
2018-05-21 11:58 ` [PATCH 23/33] drm: i2c: ch7006: " Yisheng Xie
2018-05-21 11:58 ` [PATCH 24/33] drm: " Yisheng Xie
2018-05-21 22:06 ` Andy Shevchenko
2018-05-22 8:39 ` Jani Nikula
2018-05-21 11:58 ` [PATCH 25/33] ima: " Yisheng Xie
2018-05-23 14:42 ` Mimi Zohar
2018-05-21 11:58 ` [PATCH 26/33] apparmor: " Yisheng Xie
2018-05-21 15:33 ` John Johansen
2018-05-22 1:25 ` Yisheng Xie
2018-05-21 22:10 ` Andy Shevchenko
2018-05-21 11:58 ` [PATCH 27/33] sched/debug: " Yisheng Xie
2018-05-21 22:13 ` Andy Shevchenko
2018-05-22 12:10 ` Yisheng Xie [this message]
2018-05-22 20:29 ` Andy Shevchenko
2018-05-21 11:58 ` [PATCH 28/33] ALSA: dice " Yisheng Xie
2018-05-21 22:31 ` Takashi Sakamoto
2018-05-21 11:58 ` [PATCH 29/33] ALSA: oxfw: " Yisheng Xie
2018-05-21 22:26 ` [alsa-devel] " Takashi Sakamoto
2018-05-22 7:26 ` Takashi Iwai
2018-05-21 11:58 ` [PATCH 30/33] ALSA: oxygen: " Yisheng Xie
2018-05-21 22:23 ` Andy Shevchenko
2018-05-21 11:58 ` [PATCH 31/33] ASoC: max98088: " Yisheng Xie
2018-05-21 22:24 ` Andy Shevchenko
2018-05-22 12:30 ` Yisheng Xie
2018-05-22 17:23 ` Andy Shevchenko
2018-05-21 11:58 ` [PATCH 32/33] ASoC: max98095: " Yisheng Xie
2018-05-21 22:25 ` Andy Shevchenko
2018-05-21 11:58 ` [PATCH 33/33] ASoC: dapm: " Yisheng Xie
2018-05-31 16:09 ` Applied "ASoC: dapm: use match_string() helper" to the asoc tree Mark Brown
2018-05-21 22:27 ` [PATCH 00/33] use match_string() helper Andy Shevchenko
2018-05-22 0:52 ` Yisheng Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a7108ce-a109-a1b5-ace7-38a189d2352d@huawei.com \
--to=xieyisheng1@huawei.com \
--cc=andy.shevchenko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).