linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Georgi Djakov <georgi.djakov@linaro.org>
To: Benjamin Li <benl@squareup.com>,
	Vincent Knecht <vincent.knecht@mailoo.org>,
	Jun Nie <jun.nie@linaro.org>,
	devicetree@vger.kernel.org, bjorn.andersson@linaro.org,
	agross@kernel.org, linux-pm@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	robh@kernel.org
Cc: shawn.guo@linaro.org
Subject: Re: [PATCH v2 5/5] interconnect: qcom: Add MSM8939 interconnect provider driver
Date: Wed, 3 Feb 2021 08:49:40 +0200	[thread overview]
Message-ID: <8aa03f6d-dcf5-73b3-41f8-0d872d9f4f86@linaro.org> (raw)
In-Reply-To: <7630c4aa-b023-55a6-e2aa-37a7538c6b45@squareup.com>

Hi Ben,

On 2/3/21 02:50, Benjamin Li wrote:
> On 1/5/21 5:54 AM, Georgi Djakov wrote:
>> On 1/2/21 13:08, Vincent Knecht wrote:
>>> Le vendredi 04 décembre 2020 à 15:53 +0800, Jun Nie a écrit :
>>>> Add driver for the Qualcomm interconnect buses found in MSM8939 based
>>>> platforms. The topology consists of four NoCs that are controlled by
>>>> a remote processor that collects the aggregated bandwidth for each
>>>> master-slave pairs.
>>>>
>>>> Signed-off-by: Jun Nie <jun.nie@linaro.org>
>>>
>>> Shouldn't some rpm ids be changed like they were for msm8916 in the following patch ?
>>> c497f9322af9 ("interconnect: qcom: msm8916: Remove rpm-ids from non-RPM nodes")
>>> https://patchwork.kernel.org/project/linux-arm-msm/patch/20201112105140.10092-1-georgi.djakov@linaro.org/
>>
>> Maybe they should. I don't have the hardware to try it, but the test will be
>> to just add the NoC DT nodes, enable the driver and inspect the boot log for
>> messages like:
>> [    2.926647] qcom_icc_rpm_smd_send mas X error -6
>>
>> Thanks,
>> Georgi
> 
> Hi Vincent & Georgi,
> 
> Thanks, I ran your suggestion on an MSM8939 board (with an additional
> change to print slave IDs as well). Results:
> 
> [    1.901376] qcom_icc_rpm_smd_send slv 24 error -6
> [    2.005977] qcom_icc_rpm_smd_send mas 20 error -6
> [    2.010250] qcom_icc_rpm_smd_send slv 20 error -6
> [    2.014684] qcom_icc_rpm_smd_send slv 106 error -6
> [    2.019338] qcom_icc_rpm_smd_send slv 107 error -6
> [    2.024615] qcom_icc_rpm_smd_send slv 29 error -6
> [    2.028782] qcom_icc_rpm_smd_send mas 3 error -6
> [    2.034657] qcom_icc_rpm_smd_send mas 100 error -6
> (and there's another slv 131 that's hidden by the mas 100 failure)
> 
> Jun, I'll send you the patch I tested with to silence all these errors,
> if you want to just squash that into the next version of your patchset.

Thank you for doing this! Please send a follow-up patch as i already
queued Jun's patches.

Thanks,
Georgi

      reply	other threads:[~2021-02-03  6:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-04  7:53 [PATCH v2 0/5] Consolidate RPM interconnect and support to MSM8939 Jun Nie
2020-12-04  7:53 ` [PATCH v2 1/5] interconnect: qcom: Consolidate interconnect RPM support Jun Nie
2020-12-04 18:04   ` AngeloGioacchino Del Regno
2020-12-07  1:20     ` Jun Nie
2020-12-04  7:53 ` [PATCH v2 2/5] interconnect: qcom: qcs404: use shared code Jun Nie
2020-12-04  7:53 ` [PATCH v2 3/5] dt-bindings: interconnect: single yaml file for RPM interconnect drivers Jun Nie
2020-12-04  7:53 ` [PATCH v2 4/5] dt-bindings: interconnect: Add Qualcomm MSM8939 DT bindings Jun Nie
2020-12-04  7:53 ` [PATCH v2 5/5] interconnect: qcom: Add MSM8939 interconnect provider driver Jun Nie
2021-01-02 11:08   ` Vincent Knecht
2021-01-05 13:54     ` Georgi Djakov
2021-02-03  0:50       ` Benjamin Li
2021-02-03  6:49         ` Georgi Djakov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8aa03f6d-dcf5-73b3-41f8-0d872d9f4f86@linaro.org \
    --to=georgi.djakov@linaro.org \
    --cc=agross@kernel.org \
    --cc=benl@squareup.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jun.nie@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=shawn.guo@linaro.org \
    --cc=vincent.knecht@mailoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).