From: Alexander Sverdlin <alexander.sverdlin@nokia.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Russell King <linux@armlinux.org.uk>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH v2 2/2] ARM: ftrace: Add MODULE_PLTS support
Date: Mon, 5 Mar 2018 10:18:56 +0100 [thread overview]
Message-ID: <8aa72633-5323-7f85-d326-6b7231b12aeb@nokia.com> (raw)
In-Reply-To: <20180302120026.52f34ad2@vmware.local.home>
Hello Steven!
On 02/03/18 18:00, Steven Rostedt wrote:
>> diff --git a/arch/arm/include/asm/ftrace.h b/arch/arm/include/asm/ftrace.h
>> index 9e842ff..3e663f9 100644
>> --- a/arch/arm/include/asm/ftrace.h
>> +++ b/arch/arm/include/asm/ftrace.h
>> @@ -19,6 +19,7 @@ struct dyn_arch_ftrace {
>> #ifdef CONFIG_OLD_MCOUNT
>> bool old_mcount;
>> #endif
> I think you want to add:
>
> #ifdef CONFIG_ARM_MODULE_PLTS
>> + struct module *mod;
> #endif
>
> This will add more memory overhead, and we don't want to add that if it
> is not needed.
Will include it into the next version.
Thanks for the review!
--
Best regards,
Alexander Sverdlin.
prev parent reply other threads:[~2018-03-05 9:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 16:43 [PATCH v2 0/2] ARM: Implement MODULE_PLT support in FTRACE Alexander Sverdlin
2018-03-01 16:43 ` [PATCH v2 1/2] ARM: PLT: Move struct plt_entries definition to header Alexander Sverdlin
2018-03-01 16:43 ` [PATCH v2 2/2] ARM: ftrace: Add MODULE_PLTS support Alexander Sverdlin
2018-03-02 17:00 ` Steven Rostedt
2018-03-05 9:18 ` Alexander Sverdlin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8aa72633-5323-7f85-d326-6b7231b12aeb@nokia.com \
--to=alexander.sverdlin@nokia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).