linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rajendra Nayak <rnayak@codeaurora.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>,
	agross@kernel.org, bjorn.andersson@linaro.org,
	robh+dt@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, skakit@codeaurora.org,
	swboyd@chromium.org, dianders@chromium.org, mka@chromium.org
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: sc7280-idp: Add device tree files for IDP2
Date: Thu, 5 Aug 2021 08:57:18 +0530	[thread overview]
Message-ID: <8aaef1a2-269d-1077-7996-793045a04f7c@codeaurora.org> (raw)
In-Reply-To: <0cb8bf79-697c-ff16-e37e-d1c783f8a207@somainline.org>


On 8/5/2021 1:17 AM, Konrad Dybcio wrote:
> 
> On 04.08.2021 15:03, Rajendra Nayak wrote:
>> Move all the common device tree bits for both sc7280 IDPs into a
>> sc7280-idp.dtsi and create 2 different dts files (sc7280-idp.dts
>> and sc7280-idp2.dts) in order to manage differences across the
>> IDP SKU1 and SKU2 Boards.
>> PMR735A is present on IDP board only and is not present on IDP2.
>>
>> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
>> ---
>>   arch/arm64/boot/dts/qcom/Makefile                  |   1 +
>>   arch/arm64/boot/dts/qcom/sc7280-idp.dts            | 328 +--------------------
> 
> I'm still for calling this sc7280-idp-sku1/2.dts, but other than that it looks good.

sure, I'll just wait for others to chime in, and if that's the consensus I would be
happy to re-spin.
  
> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>

Thanks.

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

      reply	other threads:[~2021-08-05  3:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-04 13:03 [PATCH v2 0/2] Add DT files for sc7280 IDP2 board Rajendra Nayak
2021-08-04 13:03 ` [PATCH v2 1/2] dt-bindings: arm: qcom: Document qcom,sc7280-idp2 board Rajendra Nayak
2021-08-04 16:28   ` Stephen Boyd
2021-08-04 13:03 ` [PATCH v2 2/2] arm64: dts: qcom: sc7280-idp: Add device tree files for IDP2 Rajendra Nayak
2021-08-04 19:47   ` Konrad Dybcio
2021-08-05  3:27     ` Rajendra Nayak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8aaef1a2-269d-1077-7996-793045a04f7c@codeaurora.org \
    --to=rnayak@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mka@chromium.org \
    --cc=robh+dt@kernel.org \
    --cc=skakit@codeaurora.org \
    --cc=swboyd@chromium.org \
    --subject='Re: [PATCH v2 2/2] arm64: dts: qcom: sc7280-idp: Add device tree files for IDP2' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).