From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B4C4C4361A for ; Fri, 4 Dec 2020 08:31:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2857622582 for ; Fri, 4 Dec 2020 08:31:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729063AbgLDIbO (ORCPT ); Fri, 4 Dec 2020 03:31:14 -0500 Received: from mout.kundenserver.de ([212.227.17.13]:42415 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725866AbgLDIbO (ORCPT ); Fri, 4 Dec 2020 03:31:14 -0500 Received: from [192.168.1.155] ([95.114.158.118]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1McY0J-1kAPBb3rJt-00cyWv; Fri, 04 Dec 2020 09:28:31 +0100 Subject: Re: [PATCH] drivers: gpio: add virtio-gpio guest driver To: Michael Walle , "Enrico Weigelt, metux IT consult" Cc: Bartosz Golaszewski , "Michael S. Tsirkin" , LKML , Linus Walleij , Jason Wang , linux-gpio , virtualization@lists.linux-foundation.org, linux-riscv@lists.infradead.org References: <20201127183003.2849-1-info@metux.net> From: "Enrico Weigelt, metux IT consult" Message-ID: <8ab347b9-8b1a-f49f-d194-f98284fa6099@metux.net> Date: Fri, 4 Dec 2020 09:28:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:dUT0JUegZ42giGfrKmvHoKDvhv2oHRjR2063rWeXiFKSlSKKSyF WV3WiUrtvsZF8oudGAy6r09BIw/6WCr/bvdKoDhqqeFsgRNMxZiIcr/bEbVJVAbNONrMlLL ZKyfCItATcn+5Cjf9IiwAlWeioaYBVHkZbBmOtEJMapTGLJGku2ayhdFc+ZdiwURrgBL1zQ eYyGWJ48hhAM00fOJggdg== X-UI-Out-Filterresults: notjunk:1;V03:K0:wJpMIBpJjRM=:Zv5F/JE0GNEQiLQcvQT3Kk pvvBPGjOoKfmD6WIu2hZZcnJuc4GTp8QcZIOCWowwKSVSAYayPuVlHPEQBSd5V6Q1xlMbogB1 ZWbgeu2rVH0pueqyXhtJgRoLMTBBdPGQ8mirjUMQ7NR1LUc9HrN2CWbR/51Ggqh4j9F9o0MuA 3acqKkusqAK1L0lguerq37BmBS7ugEVE4jJurmX+A4lhZ1+NNIpRcIr5sxHXQCmT/8aq/F1rJ KdlTugkX5k5yx9l+2MusPfQefa6xGnZpi5GRsi/CvyJh6aZDDuk3csd7iDLX6/IF/qYkGx6g1 NFg6+7jGf9gJ+bSkiuomIcRIsWd9YFvB9RV/YO+OhY1uhUajnKCIsiRRG+YX2Unkn98FNq044 wVDPk/nv94eA/WxauJpokuglPDiEl86izI+N7eEyp5db3b9Ziib556pDZqpfk Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03.12.20 23:35, Michael Walle wrote: > Am 2020-12-03 20:00, schrieb Enrico Weigelt, metux IT consult: >> On 02.12.20 15:15, Bartosz Golaszewski wrote: >>>> +               bufwalk = name_buffer; >>>> + >>>> +               while (idx < priv->num_gpios && >>>> +                      bufwalk < (name_buffer+cf.names_size)) { >>>> +                       gpio_names[idx] = (strlen(bufwalk) ? bufwalk >>>> : NULL); >>>> +                       bufwalk += strlen(bufwalk)+1; >>>> +                       idx++; >>> >>> >>> Something's wrong with indentation here. >> >> i dont think so: the "bufwalk ..." line belongs to the while expression >> and is right under the "idx", as it should be. I didn't want to break up >> at the "<" operator. shall i do this instead ? > > Or don't break the lines at all. Both lines don't add up to more than > 100 chars, > right? IIRC checkpatch complains at 80 chars. Has that been changed ? --mtx -- --- Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren GPG/PGP-Schlüssel zu. --- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@metux.net -- +49-151-27565287