From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: linus.walleij@linaro.org, Andi Shyti <andi.shyti@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH] i2c: busses: i2c-nomadik: Remove a useless call in the remove function
Date: Fri, 30 Jun 2023 22:10:40 +0200 [thread overview]
Message-ID: <8ac04af8-eff8-bfe1-647a-2d04f5739702@wanadoo.fr> (raw)
In-Reply-To: <4f4c2c5c20b61c4bb28cb3e9ab4640534dd2adec.1629530169.git.christophe.jaillet@wanadoo.fr>
Hi,
"drivers/i2c/busses/i2c-nomadik.c" just got some loved, so I was
wondering if the below patch could be reviewed.
It does not apply anymore because of the recent change, but the
explanation in the commit message and the proposed change still make
sense to me.
If it looks valid, I could send a V2.
So any feedback would be appreciated.
CJ
Le 21/08/2021 à 09:17, Christophe JAILLET a écrit :
> Since commit a410963ba4c0 ("Merge branch 'i2c-embedded/for-next' of
> git://git.pengutronix.de/git/wsa/linux"), there is no more
> 'request_mem_region()' call in this driver.
>
> So remove the 'release_mem_region()' call from the remove function which is
> likely a left over.
>
> There is no details in the above commit log, but at its end we can read:
> Conflicts:
> drivers/i2c/busses/i2c-nomadik.c
>
> This may explain why this call has been left here.
>
> Fixes: a410963ba4c0 ("Merge branch 'i2c-embedded/for-next' of git://git.pengutronix.de/git/wsa/linux
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> This patch is completely speculative and without details about commit
> a410963ba4c0 it's hard to be sure of the intent.
>
> All I can say is that it looks logical to me and that it compiles!
> ---
> drivers/i2c/busses/i2c-nomadik.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c
> index a2d12a5b1c34..e215a7357873 100644
> --- a/drivers/i2c/busses/i2c-nomadik.c
> +++ b/drivers/i2c/busses/i2c-nomadik.c
> @@ -1057,7 +1057,6 @@ static int nmk_i2c_probe(struct amba_device *adev, const struct amba_id *id)
>
> static void nmk_i2c_remove(struct amba_device *adev)
> {
> - struct resource *res = &adev->res;
> struct nmk_i2c_dev *dev = amba_get_drvdata(adev);
>
> i2c_del_adapter(&dev->adap);
> @@ -1067,7 +1066,6 @@ static void nmk_i2c_remove(struct amba_device *adev)
> /* disable the controller */
> i2c_clr_bit(dev->virtbase + I2C_CR, I2C_CR_PE);
> clk_disable_unprepare(dev->clk);
> - release_mem_region(res->start, resource_size(res));
> }
>
> static struct i2c_vendor_data vendor_stn8815 = {
next prev parent reply other threads:[~2023-06-30 20:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-21 7:17 [PATCH] i2c: busses: i2c-nomadik: Remove a useless call in the remove function Christophe JAILLET
2023-06-30 20:10 ` Christophe JAILLET [this message]
2023-06-30 21:06 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ac04af8-eff8-bfe1-647a-2d04f5739702@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=andi.shyti@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).