From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA9E6C433F5 for ; Tue, 12 Oct 2021 08:04:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B66E260E0B for ; Tue, 12 Oct 2021 08:04:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234940AbhJLIGW (ORCPT ); Tue, 12 Oct 2021 04:06:22 -0400 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:52712 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234936AbhJLIFG (ORCPT ); Tue, 12 Oct 2021 04:05:06 -0400 Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 23B9A3F2FF for ; Tue, 12 Oct 2021 08:03:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1634025781; bh=uRYagTk6MpIfpm938XTiHR//S2u2wtANBbTnjpAOHf0=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=NgJCNbn3G28wne8h7IZ8PbGMusLSGskQgaUV5A+hvM53JRMJsk1GDYoKcROpljjXc nf6lbTBHgH56cPehzwjkT8z98Og9ZxPJithaF/R6yaNQOohbEWI5kxJLWRxCmuHFwH tKn9nTRHEPxEC8nn7SgL5JR2m6zuLL7q6mUrGry9qTVCb+gI7JhHYaLxbl2mO8kPMj uk3+TBjkKQ4ajTk2araUW/DMTwxEugtkSfM5NomedHfJuCc8I7P/VB0h5kO4HBijXr GaQeTk++ZuXrnukbfgppZUX1DeAUPBNuaojSZi9quoHka3SALFkcPXQTDLooRo/tFF PTiSIwnzj+2Nw== Received: by mail-lf1-f70.google.com with SMTP id v2-20020ac25582000000b003fd1c161a31so14453226lfg.15 for ; Tue, 12 Oct 2021 01:03:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uRYagTk6MpIfpm938XTiHR//S2u2wtANBbTnjpAOHf0=; b=Hkax6qxq6siuicIf6NL15GhjV8EbUfwdtfEwzZ1HDSUJv/08O+nei4l+WvhkwfPWnh kHYttaIGOaDzyhAQ5N7b3blxi31dWF5aqoGbyjnL7Qt2D4x4XGAJE4zvSw1/hF1hHvPr 4c3oKLuOEAamt32uwXU9Fcs4M5i8IKZAXdaHW2NlE6vOsIoq5i58ASx014ZlBMU8wS/J OuiGFh0t8dpPPC7qQrfeZhw/Sv7/tjzExw4DA82jS/1uTkDbnuB8KLrtksnz54vD8hIo 1IBcQ/EBTULChN7pBLBqhRegwECUiSX96I6P4Y1zUOZUHTi72N4WggUrimt5+fE8Henb Zr9g== X-Gm-Message-State: AOAM533qa5w8uxjc9xAMF/3HxqQpFzCU1aKe/fv7DRmY1C+1tgV+K239 Mjd/DMx1NjhDWxt4zAdxNZQf8Rg21vhzKLccaTpI8dG3sh+ljMwu4UIqaymUN8iio7hO32SxIE/ 4TPW5a9f+htC4GppHVqGCoOf4zvTfWy2+Y24c5LsY0Q== X-Received: by 2002:a2e:5c43:: with SMTP id q64mr27667404ljb.224.1634025780497; Tue, 12 Oct 2021 01:03:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxWblHn4Br++Rtsc1RT2izUIH3qGN0inuK9izfQk7VScP/dXcNHCxXTuwT/b4FMiYLl8dGHnw== X-Received: by 2002:a2e:5c43:: with SMTP id q64mr27667382ljb.224.1634025780318; Tue, 12 Oct 2021 01:03:00 -0700 (PDT) Received: from [192.168.0.20] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id s11sm954282lfd.262.2021.10.12.01.02.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Oct 2021 01:02:59 -0700 (PDT) Subject: Re: [PATCH 5/8] dt-bindings: mfd: add Maxim MAX77714 PMIC To: Luca Ceresoli , linux-kernel@vger.kernel.org Cc: Lee Jones , Rob Herring , Alessandro Zummo , Alexandre Belloni , Chanwoo Choi , Bartlomiej Zolnierkiewicz , Wim Van Sebroeck , Guenter Roeck , devicetree@vger.kernel.org, linux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org, Chiwoong Byun , Laxman Dewangan References: <20211011155615.257529-1-luca@lucaceresoli.net> <20211011155615.257529-6-luca@lucaceresoli.net> From: Krzysztof Kozlowski Message-ID: <8ad40ebc-8430-9fa0-ae60-88e0d486e8cc@canonical.com> Date: Tue, 12 Oct 2021 10:02:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211011155615.257529-6-luca@lucaceresoli.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/10/2021 17:56, Luca Ceresoli wrote: > Add bindings for the MAX77714 PMIC with GPIO, RTC and watchdog. > > Signed-off-by: Luca Ceresoli > --- > .../bindings/mfd/maxim,max77714.yaml | 58 +++++++++++++++++++ > MAINTAINERS | 5 ++ > 2 files changed, 63 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/maxim,max77714.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/maxim,max77714.yaml b/Documentation/devicetree/bindings/mfd/maxim,max77714.yaml > new file mode 100644 > index 000000000000..2b0ce3b9bc92 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/maxim,max77714.yaml > @@ -0,0 +1,58 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/maxim,max77714.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MAX77714 PMIC with GPIO, RTC and watchdog from Maxim Integrated. > + > +maintainers: > + - Luca Ceresoli > + > +description: | > + MAX77714 is a Power Management IC with 4 buck regulators, 9 > + low-dropout regulators, 8 GPIOs, RTC and watchdog. > + > +properties: > + compatible: > + const: maxim,max77714 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + interrupt-controller: true > + > + "#interrupt-cells": > + const: 2 > + description: > + The first cell is the IRQ number, the second cell is the trigger type. > + > +required: > + - compatible > + - reg > + - interrupts > + - interrupt-controller > + - "#interrupt-cells" > + > +additionalProperties: false > + > +examples: > + - | > + #include > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + pmic@1c { > + compatible = "maxim,max77714"; > + reg = <0x1c>; > + interrupt-parent = <&gpio2>; > + interrupts = <3 IRQ_TYPE_LEVEL_LOW>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + }; Looks good to me, but what about regulators and other properties? Are you planning to add them later? Best regards, Krzysztof