From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F09FCC433F5 for ; Mon, 11 Apr 2022 12:30:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346181AbiDKMc1 (ORCPT ); Mon, 11 Apr 2022 08:32:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346094AbiDKMcO (ORCPT ); Mon, 11 Apr 2022 08:32:14 -0400 Received: from out30-42.freemail.mail.aliyun.com (out30-42.freemail.mail.aliyun.com [115.124.30.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 170233EBB9; Mon, 11 Apr 2022 05:29:58 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01424;MF=jefflexu@linux.alibaba.com;NM=1;PH=DS;RN=18;SR=0;TI=SMTPD_---0V9pDkdH_1649680193; Received: from 30.225.24.83(mailfrom:jefflexu@linux.alibaba.com fp:SMTPD_---0V9pDkdH_1649680193) by smtp.aliyun-inc.com(127.0.0.1); Mon, 11 Apr 2022 20:29:55 +0800 Message-ID: <8aef9756-9a71-de36-d5b7-e9c32156afa3@linux.alibaba.com> Date: Mon, 11 Apr 2022 20:29:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v8 02/20] cachefiles: extract write routine Content-Language: en-US To: David Howells Cc: linux-cachefs@redhat.com, xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org, torvalds@linux-foundation.org, gregkh@linuxfoundation.org, willy@infradead.org, linux-fsdevel@vger.kernel.org, joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com, tao.peng@linux.alibaba.com, gerry@linux.alibaba.com, eguan@linux.alibaba.com, linux-kernel@vger.kernel.org, luodaowen.backend@bytedance.com, tianzichen@kuaishou.com, fannaihao@baidu.com References: <20220406075612.60298-3-jefflexu@linux.alibaba.com> <20220406075612.60298-1-jefflexu@linux.alibaba.com> <1090420.1649679186@warthog.procyon.org.uk> From: JeffleXu In-Reply-To: <1090420.1649679186@warthog.procyon.org.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/11/22 8:13 PM, David Howells wrote: > Jeffle Xu wrote: > >> It is worth nothing that, ki->inval_counter is not initialized after >> this cleanup. > > I think you meant "It is worth noting that, ...". Yeah... > > Btw, is there a particular reason that you didn't want to pass in a pointer to > a netfs_cache_resources struct? IMHO, "struct netfs_cache_resources" is more like an interface for netfs, while here __cachefiles_prepare_write() and __cachefiles_write() are called inside Cachefiles module. -- Thanks, Jeffle