From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Yinbo Zhu <yinbo.zhu@nxp.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: fsl,p2020-esdhc sdhci quirks
Date: Tue, 3 Dec 2019 11:15:37 +0100 [thread overview]
Message-ID: <8afd0f53-eba8-e000-d8cc-b464e65850c3@rasmusvillemoes.dk> (raw)
Hi
Commits
05cb6b2a66fa - mmc: sdhci-of-esdhc: add erratum eSDHC-A001 and A-008358
support
a46e42712596 - mmc: sdhci-of-esdhc: add erratum eSDHC5 support
seem a bit odd, in that they set bits from the SDHCI_* namespace in the
->quirks2 member:
host->quirks2 |= SDHCI_QUIRK_RESET_AFTER_REQUEST;
host->quirks2 |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
These are bits 10 and 12, so they are also known as
SDHCI_QUIRK2_CLEAR_TRANSFERMODE_REG_BEFORE_CMD and
SDHCI_QUIRK2_TUNING_WORK_AROUND. So if the fixes are correct, one should
use those names on the right-hand side, but it seems just as likely (I
can't figure that out from the commit messages) that the left-hand sides
should have been host->quirks ?
Rasmus
next reply other threads:[~2019-12-03 10:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 10:15 Rasmus Villemoes [this message]
2019-12-03 10:49 ` fsl,p2020-esdhc sdhci quirks Rasmus Villemoes
2019-12-03 11:15 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8afd0f53-eba8-e000-d8cc-b464e65850c3@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=yinbo.zhu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).