From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB276C6FD1C for ; Sat, 11 Mar 2023 14:54:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230024AbjCKOyD (ORCPT ); Sat, 11 Mar 2023 09:54:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229541AbjCKOyB (ORCPT ); Sat, 11 Mar 2023 09:54:01 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D60F117206; Sat, 11 Mar 2023 06:54:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=iHHKRP69W43ACLoWxboDmANBtskKavjkbphy802RNys=; b=l2tGtxSh6V/nPKGtMzIdOJk2p6 ZBNJu7ocSQpaOh750qKqSi2SWNH5teX4T16hzR/cYMKkz6rwy8jA9mnEwHmSzJq8cfHQlGBtucR/z 2F2c37lgL283fhfhs1BDcyHbMDa5lWfXfQ3RBvOXut9Rrnk/eh0gXPlmsxw+8lT0IkEs=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1pb0bW-00749q-Hy; Sat, 11 Mar 2023 15:53:50 +0100 Date: Sat, 11 Mar 2023 15:53:50 +0100 From: Andrew Lunn To: Klaus Kudielka Cc: Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] net: dsa: mv88e6xxx: re-order functions Message-ID: <8affe7aa-55d3-4e96-b39a-99049ca8cd84@lunn.ch> References: <20230311094141.34578-1-klaus.kudielka@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230311094141.34578-1-klaus.kudielka@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 11, 2023 at 10:41:40AM +0100, Klaus Kudielka wrote: > Move mv88e6xxx_setup() below mv88e6xxx_mdios_register(), so that we are > able to call the latter one from here. Do the same thing for the > inverse functions. > > Signed-off-by: Klaus Kudielka Hi Klaus If this your first patchset for netdev? There are a few process issues you missed. Please take a look at: https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html This patchset if for net-next, so the subject should indicate that. It is also normal to include a patch 0/X which explains the big picture. Part of the commit message you have in patch 2/2 would then appear in 0/2. Reviewed-by: Andrew Lunn Andrew