From: Hanjun Guo <guohanjun@huawei.com>
To: Zenghui Yu <yuzenghui@huawei.com>, <lorenzo.pieralisi@arm.com>,
<sudeep.holla@arm.com>
Cc: <linux-acpi@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <wanghaibin.wang@huawei.com>
Subject: Re: [PATCH] ACPI/IORT: Drop the unused @ops of iort_add_device_replay()
Date: Tue, 18 Aug 2020 11:49:52 +0800 [thread overview]
Message-ID: <8b15f022-8fb9-aa5c-fcd8-f92d4878a0a3@huawei.com> (raw)
In-Reply-To: <20200817105946.1511-1-yuzenghui@huawei.com>
On 2020/8/17 18:59, Zenghui Yu wrote:
> Since commit d2e1a003af56 ("ACPI/IORT: Don't call iommu_ops->add_device
> directly"), we use the IOMMU core API to replace a direct invoke of the
> specified callback. The parameter @ops has therefore became unused. Let's
> drop it.
>
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
> ---
> drivers/acpi/arm64/iort.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
> index ec782e4a0fe4..a0ece0e201b2 100644
> --- a/drivers/acpi/arm64/iort.c
> +++ b/drivers/acpi/arm64/iort.c
> @@ -811,8 +811,7 @@ static inline const struct iommu_ops *iort_fwspec_iommu_ops(struct device *dev)
> return (fwspec && fwspec->ops) ? fwspec->ops : NULL;
> }
>
> -static inline int iort_add_device_replay(const struct iommu_ops *ops,
> - struct device *dev)
> +static inline int iort_add_device_replay(struct device *dev)
> {
> int err = 0;
>
> @@ -1072,7 +1071,7 @@ const struct iommu_ops *iort_iommu_configure_id(struct device *dev,
> */
> if (!err) {
> ops = iort_fwspec_iommu_ops(dev);
> - err = iort_add_device_replay(ops, dev);
> + err = iort_add_device_replay(dev);
> }
>
> /* Ignore all other errors apart from EPROBE_DEFER */
> @@ -1089,8 +1088,7 @@ const struct iommu_ops *iort_iommu_configure_id(struct device *dev,
> #else
> static inline const struct iommu_ops *iort_fwspec_iommu_ops(struct device *dev)
> { return NULL; }
> -static inline int iort_add_device_replay(const struct iommu_ops *ops,
> - struct device *dev)
> +static inline int iort_add_device_replay(struct device *dev)
inline functions iort_fwspec_iommu_ops() and iort_add_device_replay()
are not needed anymore after commit 8212688600ed ("ACPI/IORT: Fix build
error when IOMMU_SUPPORT is disabled"), could you please add another
patch to remove them as well?
Thanks
Hanjun
next prev parent reply other threads:[~2020-08-18 3:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 10:59 [PATCH] ACPI/IORT: Drop the unused @ops of iort_add_device_replay() Zenghui Yu
2020-08-18 3:49 ` Hanjun Guo [this message]
2020-08-18 6:29 ` Zenghui Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b15f022-8fb9-aa5c-fcd8-f92d4878a0a3@huawei.com \
--to=guohanjun@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=sudeep.holla@arm.com \
--cc=wanghaibin.wang@huawei.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).