From: Adrian Hunter <adrian.hunter@intel.com>
To: Chanwoo Lee <cw9316.lee@samsung.com>,
ulf.hansson@linaro.org, colyli@suse.de, axboe@kernel.dk,
ebiggers@google.com, pcc@google.com, porzio@gmail.com,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: grant.jung@samsung.com, jt77.jang@samsung.com,
dh0421.hwang@samsung.com, sh043.lee@samsung.com
Subject: Re: [PATCH v2] mmc: queue: Remove unused parameters(request_queue)
Date: Wed, 25 Aug 2021 11:58:39 +0300 [thread overview]
Message-ID: <8b189f2d-dfe3-b23e-9598-668b8509f501@intel.com> (raw)
In-Reply-To: <20210825074601.8881-1-cw9316.lee@samsung.com>
On 25/08/21 10:46 am, Chanwoo Lee wrote:
> From: ChanWoo Lee <cw9316.lee@samsung.com>
>
> In function mmc_exit_request, the request_queue structure(*q) is not used.
> I remove the unnecessary code related to the request_queue structure.
>
> Signed-off-by: ChanWoo Lee <cw9316.lee@samsung.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
>
> ---
> v1->v2:
> * Put the code directly into mmc_mq_init_reuqest()/mmc_mq_exit_request().
> ---
> drivers/mmc/core/queue.c | 30 ++++++------------------------
> 1 file changed, 6 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c
> index cc3261777637..5526e4ca2834 100644
> --- a/drivers/mmc/core/queue.c
> +++ b/drivers/mmc/core/queue.c
> @@ -199,27 +199,23 @@ static unsigned int mmc_get_max_segments(struct mmc_host *host)
> host->max_segs;
> }
>
> -/**
> - * mmc_init_request() - initialize the MMC-specific per-request data
> - * @mq: the request queue
> - * @req: the request
> - * @gfp: memory allocation policy
> - */
> -static int __mmc_init_request(struct mmc_queue *mq, struct request *req,
> - gfp_t gfp)
> +static int mmc_mq_init_request(struct blk_mq_tag_set *set, struct request *req,
> + unsigned int hctx_idx, unsigned int numa_node)
> {
> struct mmc_queue_req *mq_rq = req_to_mmc_queue_req(req);
> + struct mmc_queue *mq = set->driver_data;
> struct mmc_card *card = mq->card;
> struct mmc_host *host = card->host;
>
> - mq_rq->sg = mmc_alloc_sg(mmc_get_max_segments(host), gfp);
> + mq_rq->sg = mmc_alloc_sg(mmc_get_max_segments(host), GFP_KERNEL);
> if (!mq_rq->sg)
> return -ENOMEM;
>
> return 0;
> }
>
> -static void mmc_exit_request(struct request_queue *q, struct request *req)
> +static void mmc_mq_exit_request(struct blk_mq_tag_set *set, struct request *req,
> + unsigned int hctx_idx)
> {
> struct mmc_queue_req *mq_rq = req_to_mmc_queue_req(req);
>
> @@ -227,20 +223,6 @@ static void mmc_exit_request(struct request_queue *q, struct request *req)
> mq_rq->sg = NULL;
> }
>
> -static int mmc_mq_init_request(struct blk_mq_tag_set *set, struct request *req,
> - unsigned int hctx_idx, unsigned int numa_node)
> -{
> - return __mmc_init_request(set->driver_data, req, GFP_KERNEL);
> -}
> -
> -static void mmc_mq_exit_request(struct blk_mq_tag_set *set, struct request *req,
> - unsigned int hctx_idx)
> -{
> - struct mmc_queue *mq = set->driver_data;
> -
> - mmc_exit_request(mq->queue, req);
> -}
> -
> static blk_status_t mmc_mq_queue_rq(struct blk_mq_hw_ctx *hctx,
> const struct blk_mq_queue_data *bd)
> {
>
next prev parent reply other threads:[~2021-08-25 8:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210825075311epcas1p4b64d6a5a824983c91f7d5d1dc24a4cc2@epcas1p4.samsung.com>
2021-08-25 7:46 ` [PATCH v2] mmc: queue: Remove unused parameters(request_queue) Chanwoo Lee
2021-08-25 8:58 ` Adrian Hunter [this message]
2021-08-25 9:22 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b189f2d-dfe3-b23e-9598-668b8509f501@intel.com \
--to=adrian.hunter@intel.com \
--cc=axboe@kernel.dk \
--cc=colyli@suse.de \
--cc=cw9316.lee@samsung.com \
--cc=dh0421.hwang@samsung.com \
--cc=ebiggers@google.com \
--cc=grant.jung@samsung.com \
--cc=jt77.jang@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=pcc@google.com \
--cc=porzio@gmail.com \
--cc=sh043.lee@samsung.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).