From: David Hildenbrand <david@redhat.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Gerald Schaefer <gerald.schaefer@de.ibm.com>,
Mikhail Zaslonko <zaslonko@linux.ibm.com>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Pavel.Tatashin@microsoft.com,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com
Subject: Re: [PATCH v2 1/1] mm, memory_hotplug: Initialize struct pages for the full memory section
Date: Mon, 17 Dec 2018 14:29:04 +0100 [thread overview]
Message-ID: <8b1bc4ff-0a30-573c-94c3-a8d943cd291c@redhat.com> (raw)
In-Reply-To: <20181217122812.GJ30879@dhcp22.suse.cz>
On 17.12.18 13:28, Michal Hocko wrote:
> On Mon 17-12-18 10:38:32, David Hildenbrand wrote:
> [...]
>> I am wondering if we should fix this on the memblock level instead than.
>> Something like, before handing memory over to the page allocator, add
>> memory as reserved up to the last section boundary. Or even when setting
>> the physical memory limit (mem= scenario).
>
> Memory initialization is spread over several places and that makes it
> really hard to grasp and maintain. I do not really see why we should
> make memblock even more special. We do intialize the section worth of
> memory here so it sounds like a proper place to quirk for incomplete
> sections.
>
True as well. The reason I am asking is, that memblock usually takes
care of physical memory holes.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2018-12-17 13:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 17:27 [PATCH v2 0/1] Initialize struct pages for the full section Mikhail Zaslonko
2018-12-12 17:27 ` [PATCH v2 1/1] mm, memory_hotplug: Initialize struct pages for the full memory section Mikhail Zaslonko
2018-12-13 3:46 ` Wei Yang
[not found] ` <e4cebbae-3fcb-f03c-3d0e-a1a44ff0675a@linux.bm.com>
2018-12-13 15:12 ` Wei Yang
[not found] ` <674c53e2-e4b3-f21f-4613-b149acef7e53@linux.bm.com>
2018-12-14 10:19 ` Michal Hocko
2018-12-15 0:26 ` Wei Yang
2018-12-13 12:59 ` Michal Hocko
2018-12-14 15:22 ` David Hildenbrand
2018-12-14 15:49 ` David Hildenbrand
2018-12-14 19:23 ` Gerald Schaefer
2018-12-17 9:38 ` David Hildenbrand
2018-12-17 12:28 ` Michal Hocko
2018-12-17 13:29 ` David Hildenbrand [this message]
2018-12-17 13:35 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b1bc4ff-0a30-573c-94c3-a8d943cd291c@redhat.com \
--to=david@redhat.com \
--cc=Pavel.Tatashin@microsoft.com \
--cc=akpm@linux-foundation.org \
--cc=gerald.schaefer@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=zaslonko@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).