From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: jolsa@kernel.org, Linux-kernel@vger.kernel.org,
ak@linux.intel.com, kan.liang@intel.com
Subject: Re: [PATCH v4 4/6] perf report: Show branch info in callchain entry for stdio mode
Date: Tue, 15 Nov 2016 08:45:55 +0800 [thread overview]
Message-ID: <8b24da20-d7d4-68ee-819a-1e3051768f97@linux.intel.com> (raw)
In-Reply-To: <20161114163448.GE26543@kernel.org>
Sorry, spelling mistake.
It should be "predicted" and "is hidden". Thanks for correcting on that.
Thanks
Jin Yao
On 11/15/2016 12:34 AM, Arnaldo Carvalho de Melo wrote:
> Em Mon, Oct 31, 2016 at 09:19:52AM +0800, Jin Yao escreveu:
>> If the branch is 100% predicated then the "predicated" is hide.
> "predicated"? Changing this to "predicted".
>
> Also changing "is hide" to "is hidden".
>
> - Arnaldo
>
>> Similarly, if there is no branch tsx abort, the "abort" is hide.
>> There is only cycles shown (cycle is supported on skylake platform,
>> older platform would be 0).
>>
>> If no iterations, the "iterations" is hide.
>>
>> For example:
>>
>> |--29.93%--main div.c:39 (predicted:50.6%, cycles:1, iterations:18)
>> | main div.c:44 (predicted:50.6%, cycles:1)
>> | |
>> | --22.69%--main div.c:42 (cycles:2, iterations:17)
>> | compute_flag div.c:28 (cycles:2)
>> | |
>> | --10.52%--compute_flag div.c:27 (cycles:1)
>> | rand rand.c:28 (cycles:1)
>> | rand rand.c:28 (cycles:1)
>> | __random random.c:298 (cycles:1)
>> | __random random.c:297 (cycles:1)
>> | __random random.c:295 (cycles:1)
>> | __random random.c:295 (cycles:1)
>> | __random random.c:295 (cycles:1)
>> | __random random.c:295 (cycles:6)
>>
>> Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
>> ---
>> tools/perf/ui/stdio/hist.c | 35 +++++++++++++++++++++++++++++++----
>> 1 file changed, 31 insertions(+), 4 deletions(-)
>>
>> diff --git a/tools/perf/ui/stdio/hist.c b/tools/perf/ui/stdio/hist.c
>> index 89d8441..668f4ae 100644
>> --- a/tools/perf/ui/stdio/hist.c
>> +++ b/tools/perf/ui/stdio/hist.c
>> @@ -41,7 +41,9 @@ static size_t ipchain__fprintf_graph(FILE *fp, struct callchain_node *node,
>> {
>> int i;
>> size_t ret = 0;
>> - char bf[1024];
>> + char bf[1024], *alloc_str = NULL;
>> + char buf[64];
>> + const char *str;
>>
>> ret += callchain__fprintf_left_margin(fp, left_margin);
>> for (i = 0; i < depth; i++) {
>> @@ -56,8 +58,26 @@ static size_t ipchain__fprintf_graph(FILE *fp, struct callchain_node *node,
>> } else
>> ret += fprintf(fp, "%s", " ");
>> }
>> - fputs(callchain_list__sym_name(chain, bf, sizeof(bf), false), fp);
>> +
>> + str = callchain_list__sym_name(chain, bf, sizeof(bf), false);
>> +
>> + if (symbol_conf.show_branchflag_count) {
>> + if (!period)
>> + callchain_list_counts__printf_value(node, chain, NULL,
>> + buf, sizeof(buf));
>> + else
>> + callchain_list_counts__printf_value(NULL, chain, NULL,
>> + buf, sizeof(buf));
>> +
>> + if (asprintf(&alloc_str, "%s%s", str, buf) < 0)
>> + str = "Not enough memory!";
>> + else
>> + str = alloc_str;
>> + }
>> +
>> + fputs(str, fp);
> q> fputc('\n', fp);
>> + free(alloc_str);
>> return ret;
>> }
>>
>> @@ -219,8 +239,15 @@ static size_t callchain__fprintf_graph(FILE *fp, struct rb_root *root,
>> } else
>> ret += callchain__fprintf_left_margin(fp, left_margin);
>>
>> - ret += fprintf(fp, "%s\n", callchain_list__sym_name(chain, bf, sizeof(bf),
>> - false));
>> + ret += fprintf(fp, "%s",
>> + callchain_list__sym_name(chain, bf,
>> + sizeof(bf),
>> + false));
>> +
>> + if (symbol_conf.show_branchflag_count)
>> + ret += callchain_list_counts__printf_value(
>> + NULL, chain, fp, NULL, 0);
>> + ret += fprintf(fp, "\n");
>>
>> if (++entries_printed == callchain_param.print_limit)
>> break;
>> --
>> 2.7.4
next prev parent reply other threads:[~2016-11-15 0:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-31 1:19 [PATCH v4 0/6] perf report: Show branch flags/cycles in --branch-history callgraph view Jin Yao
2016-10-31 1:19 ` [PATCH v4 1/6] perf report: Add branch flag to callchain cursor node Jin Yao
2016-10-31 1:19 ` [PATCH v4 2/6] perf report: Create a symbol_conf flag for showing branch flag counting Jin Yao
2016-11-15 10:47 ` [tip:perf/core] " tip-bot for Jin Yao
2016-10-31 1:19 ` [PATCH v4 3/6] perf report: Caculate and return the " Jin Yao
2016-11-15 10:47 ` [tip:perf/core] perf report: Calculate " tip-bot for Jin Yao
2016-10-31 1:19 ` [PATCH v4 4/6] perf report: Show branch info in callchain entry for stdio mode Jin Yao
2016-11-14 16:34 ` Arnaldo Carvalho de Melo
2016-11-15 0:45 ` Jin, Yao [this message]
2016-11-15 10:48 ` [tip:perf/core] " tip-bot for Jin Yao
2016-10-31 1:19 ` [PATCH v4 5/6] perf report: Show branch info in callchain entry for browser mode Jin Yao
2016-11-15 10:49 ` [tip:perf/core] " tip-bot for Jin Yao
2016-10-31 1:19 ` [PATCH v4 6/6] perf report: Display columns Predicted/Abort/Cycles in --branch-history Jin Yao
2016-11-14 14:30 ` [PATCH v4 0/6] perf report: Show branch flags/cycles in --branch-history callgraph view Arnaldo Carvalho de Melo
2016-11-14 14:49 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b24da20-d7d4-68ee-819a-1e3051768f97@linux.intel.com \
--to=yao.jin@linux.intel.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).