linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sameer Pujar <spujar@nvidia.com>
To: Mark Brown <broonie@kernel.org>
Cc: <spujar@nvidia.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	<perex@perex.cz>, <tiwai@suse.com>, <robh+dt@kernel.org>,
	<lgirdwood@gmail.com>, <thierry.reding@gmail.com>,
	<jonathanh@nvidia.com>, <digetx@gmail.com>,
	<alsa-devel@alsa-project.org>, <linux-tegra@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <sharadg@nvidia.com>,
	<mkumard@nvidia.com>, <viswanathl@nvidia.com>,
	<rlokhande@nvidia.com>, <dramesh@nvidia.com>,
	<atalambedu@nvidia.com>, <nwartikar@nvidia.com>,
	<swarren@nvidia.com>, <nicoleotsuka@gmail.com>
Subject: Re: Re: [PATCH v4 11/23] ASoC: simple-card: Loop over all children for 'mclk-fs'
Date: Tue, 30 Jun 2020 17:26:32 +0530	[thread overview]
Message-ID: <8b264575-08e7-64c5-fd7c-3109a0a36ce8@nvidia.com> (raw)
In-Reply-To: <20200630105532.GG5272@sirena.org.uk>



On 6/30/2020 4:25 PM, Mark Brown wrote:
> On Tue, Jun 30, 2020 at 09:53:13AM +0530, Sameer Pujar wrote:
>> On 6/30/2020 7:38 AM, Kuninori Morimoto wrote:
>>> External email: Use caution opening links or attachments
>>>>>> +     if (cpu != codec)
>>>>>> +             of_property_read_u32(codec, prop, &props->mclk_fs);
>> Sorry if I was not clear before.
> I agree with Moromito-san that the new code (especially the above bit)
> is very confusing, I'm not sure how the reader is supposed to figure out
> what the purpose of the check is or how the CPU could ever be the CODEC.
>
>> simple_parse_mclk_fs() is used by both simple_dai_link_of_dpcm() and
>> simple_dai_link_of(). To make the same API work for both the cases, I had to
>> use (A) in DPCM function. Now (B) does not get used for
>> simple_dai_link_of_dpcm(), but will get used by simple_dai_link_of().
>> If it is simpler I will just avoid 'cpu != codec' check and keep the
>> function simple_parse_mclk_fs() as it is.
> That'd definitely be simpler, or supporting this with a CPU node as
> well.

OK. I will keep it simple.


  reply	other threads:[~2020-06-30 11:56 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-27  4:53 [PATCH v4 00/23] Add support for Tegra210 Audio Sameer Pujar
2020-06-27  4:53 ` [PATCH v4 01/23] ASoC: dt-bindings: tegra: Add DT bindings for Tegra210 Sameer Pujar
2020-06-27  4:53 ` [PATCH v4 02/23] ASoC: tegra: Add support for CIF programming Sameer Pujar
2020-06-27  4:53 ` [PATCH v4 03/23] ASoC: tegra: Add Tegra210 based DMIC driver Sameer Pujar
2020-06-27  4:53 ` [PATCH v4 04/23] ASoC: tegra: Add Tegra210 based I2S driver Sameer Pujar
2020-06-27  4:53 ` [PATCH v4 05/23] ASoC: tegra: Add Tegra210 based AHUB driver Sameer Pujar
2020-06-27  4:53 ` [PATCH v4 06/23] ASoC: tegra: Add Tegra186 based DSPK driver Sameer Pujar
2020-06-27  4:53 ` [PATCH v4 07/23] ASoC: tegra: Add Tegra210 based ADMAIF driver Sameer Pujar
2020-06-27  4:53 ` [PATCH v4 08/23] ASoC: soc-core: Fix component name_prefix parsing Sameer Pujar
2020-06-29  0:38   ` Kuninori Morimoto
2020-06-29 15:46     ` Sameer Pujar
2020-06-30 10:45   ` Mark Brown
2020-06-30 12:56     ` Sameer Pujar
2020-06-27  4:53 ` [PATCH v4 09/23] ASoC: simple-card: Use of_node and DAI names for DAI link names Sameer Pujar
2020-06-27  4:53 ` [PATCH v4 10/23] ASoC: simple-card: Wrong daifmt for CPU end of DPCM DAI link Sameer Pujar
2020-06-29  0:56   ` Kuninori Morimoto
     [not found]     ` <6e27daa5-331e-968b-4027-2e30aeb7d382@nvidia.com>
2020-06-30  0:56       ` Kuninori Morimoto
2020-06-30  3:47         ` Sameer Pujar
2020-06-30  5:07           ` Kuninori Morimoto
2020-06-27  4:53 ` [PATCH v4 11/23] ASoC: simple-card: Loop over all children for 'mclk-fs' Sameer Pujar
2020-06-29  1:05   ` Kuninori Morimoto
2020-06-29 16:32     ` Sameer Pujar
2020-06-30  2:08       ` Kuninori Morimoto
2020-06-30  4:23         ` Sameer Pujar
2020-06-30 10:55           ` Mark Brown
2020-06-30 11:56             ` Sameer Pujar [this message]
2020-06-27  4:53 ` [PATCH v4 12/23] ASoC: simple-card: Support DPCM DAI link with multiple Codecs Sameer Pujar
2020-06-29  1:24   ` Kuninori Morimoto
2020-06-29 17:16     ` Sameer Pujar
2020-06-30  1:24       ` Kuninori Morimoto
2020-06-30  4:08         ` Sameer Pujar
2020-06-30  6:55           ` Kuninori Morimoto
2020-06-30  7:52             ` Sameer Pujar
2020-06-30 11:01               ` Mark Brown
2020-06-30 12:53                 ` Sameer Pujar
2020-06-30 15:32                   ` Mark Brown
2020-07-02 10:36                     ` Sameer Pujar
2020-07-02 12:26                       ` Mark Brown
2020-07-17 12:55                         ` Sameer Pujar
2020-06-27  4:53 ` [PATCH v4 13/23] ASoC: simple-card: DPCM DAI link direction as per DAI capability Sameer Pujar
2020-06-27  4:53 ` [PATCH v4 14/23] ASoC: soc-core: Probe auxiliary component before others Sameer Pujar
2020-06-27  4:53 ` [PATCH v4 15/23] ASoC: soc-core: Identify 'no_pcm' DAI links for DPCM Sameer Pujar
2020-06-29  1:38   ` Kuninori Morimoto
2020-06-29 17:19     ` Sameer Pujar
2020-06-30  6:07   ` Kuninori Morimoto
2020-06-30  8:03     ` Sameer Pujar
2020-07-02  0:52       ` Kuninori Morimoto
2020-07-02  3:48         ` Sameer Pujar
2020-07-02  8:50           ` Kuninori Morimoto
2020-07-02  9:56             ` Sameer Pujar
2020-06-27  4:53 ` [PATCH v4 16/23] ASoC: soc-pcm: Get all BEs along DAPM path Sameer Pujar
2020-06-29  1:41   ` Kuninori Morimoto
2020-06-29 17:29     ` Sameer Pujar
2020-06-27  4:53 ` [PATCH v4 17/23] ASoC: dt-bindings: simple-card: Add compatible for component chaining Sameer Pujar
2020-06-27  4:53 ` [PATCH v4 18/23] ASoC: simple-card: Add support " Sameer Pujar
2020-06-27  4:53 ` [PATCH v4 19/23] arm64: defconfig: Build AHUB component drivers Sameer Pujar
2020-06-27  4:53 ` [PATCH v4 20/23] arm64: defconfig: Enable CONFIG_TEGRA210_ADMA Sameer Pujar
2020-06-27  4:53 ` [PATCH v4 21/23] arm64: tegra: Add DT binding for AHUB components Sameer Pujar
2020-06-27  4:53 ` [PATCH v4 22/23] arm64: tegra: Enable AHUB components on few Tegra platforms Sameer Pujar
2020-06-27  4:53 ` [PATCH v4 23/23] arm64: tegra: Add support for APE sound card on Jetson Nano and TX1 Sameer Pujar
2020-06-30 10:51 ` [PATCH v4 00/23] Add support for Tegra210 Audio Mark Brown
2020-06-30 11:54   ` Sameer Pujar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b264575-08e7-64c5-fd7c-3109a0a36ce8@nvidia.com \
    --to=spujar@nvidia.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=atalambedu@nvidia.com \
    --cc=broonie@kernel.org \
    --cc=digetx@gmail.com \
    --cc=dramesh@nvidia.com \
    --cc=jonathanh@nvidia.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mkumard@nvidia.com \
    --cc=nicoleotsuka@gmail.com \
    --cc=nwartikar@nvidia.com \
    --cc=perex@perex.cz \
    --cc=rlokhande@nvidia.com \
    --cc=robh+dt@kernel.org \
    --cc=sharadg@nvidia.com \
    --cc=swarren@nvidia.com \
    --cc=thierry.reding@gmail.com \
    --cc=tiwai@suse.com \
    --cc=viswanathl@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).