From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0C85C3A5A3 for ; Thu, 29 Aug 2019 17:01:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B4B12339E for ; Thu, 29 Aug 2019 17:01:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567098088; bh=wBHheJcf0m1hNSCx9WaNoXmRMBlMJkFkSTAD62zxQXc=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=T7xxOKx8L5MXx1eFE2TeAzpnb6Sx5zC4j20YfvQ0S8DOFlzPudIbJC8Y+b9D8w/RS deRzNLmXKaogkw3xlblimtmK27StHXVrm9ksg6P81l1GpCpjlWSG1BKxP2U6IVj+bb CpjvnUqmll4h24wug2AqdZ6oePa7o8IZP20ghSKY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727707AbfH2RB1 (ORCPT ); Thu, 29 Aug 2019 13:01:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:56258 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726739AbfH2RB1 (ORCPT ); Thu, 29 Aug 2019 13:01:27 -0400 Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2B9FF21726; Thu, 29 Aug 2019 17:01:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567098084; bh=wBHheJcf0m1hNSCx9WaNoXmRMBlMJkFkSTAD62zxQXc=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=m8iAap6KIvI0VP/V3DIBBy43SPrKlEiKYwcg/DCgjayaEgWAFYCCoU8mgmDKsGRpO UXh7/TW4n79p1MN4UVopT+8X09zzYmgf2kjBFwav1qBIQuSf080T50SJnmAtH+H0Pw gWHHOWx23iKv4a3Xh1lbqdYF32NPDNgRg9FFRox4= Subject: Re: [PATCH v2] kunit: fix failure to build without printk To: Sergey Senozhatsky , Brendan Higgins , Joe Perches Cc: kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, frowand.list@gmail.com, sboyd@kernel.org, pmladek@suse.com, sergey.senozhatsky@gmail.com, rostedt@goodmis.org, Randy Dunlap , Stephen Rothwell , shuah References: <20190828093143.163302-1-brendanhiggins@google.com> <20190828094929.GA14038@jagdpanzerIV> From: shuah Message-ID: <8b2d63bf-56cd-e8f5-e8ee-2891c2c1be8f@kernel.org> Date: Thu, 29 Aug 2019 11:01:08 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190828094929.GA14038@jagdpanzerIV> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/28/19 3:49 AM, Sergey Senozhatsky wrote: > On (08/28/19 02:31), Brendan Higgins wrote: > [..] >> Previously KUnit assumed that printk would always be present, which is >> not a valid assumption to make. Fix that by removing call to >> vprintk_emit, and calling printk directly. >> >> Reported-by: Randy Dunlap >> Link: https://lore.kernel.org/linux-kselftest/0352fae9-564f-4a97-715a-fabe016259df@kernel.org/T/#t >> Cc: Stephen Rothwell >> Cc: Sergey Senozhatsky >> Signed-off-by: Brendan Higgins > > [..] > >> -static void kunit_vprintk(const struct kunit *test, >> - const char *level, >> - struct va_format *vaf) >> -{ >> - kunit_printk_emit(level[1] - '0', "\t# %s: %pV", test->name, vaf); >> -} > > This patch looks good to me. I like the removal of recursive > vsprintf() (%pV). > > -ss > Hi Sergey, What are the guidelines for using printk(). I recall some discussion about not using printk(). I am seeing the following from checkpatch script: WARNING: Prefer [subsystem eg: netdev]_level([subsystem]dev, ... then dev_level(dev, ... then pr_level(... to printk(KERN_LEVEL ... #105: FILE: include/kunit/test.h:343: + printk(KERN_LEVEL "\t# %s: " fmt, (test)->name, ##__VA_ARGS__) Is there supposed to be pr_level() - I can find dev_level() cc'ing Joe Perches for his feedback on this message recommending pr_level() which isn't in 5.3. thanks, -- Shuah thanks, -- Shuah