From: Philippe Schenker <philippe.schenker@toradex.com>
To: "alexandre.torgue@foss.st.com" <alexandre.torgue@foss.st.com>,
"linmq006@gmail.com" <linmq006@gmail.com>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"keescook@chromium.org" <keescook@chromium.org>,
"lars@metafoo.de" <lars@metafoo.de>,
"jic23@kernel.org" <jic23@kernel.org>,
"mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: stmpe-adc: Fix wait_for_completion_timeout return value check
Date: Mon, 11 Apr 2022 12:05:36 +0000 [thread overview]
Message-ID: <8b40cdebc07ff7ca29aa9fc03b8d9c40754ab4bd.camel@toradex.com> (raw)
In-Reply-To: <20220411103032.14038-1-linmq006@gmail.com>
On Mon, 2022-04-11 at 10:30 +0000, Miaoqian Lin wrote:
> wait_for_completion_timeout() returns unsigned long not long.
> it returns 0 if timed out, and positive if completed.
> The check for <= 0 is ambiguous and should be == 0 here
> indicating timeout which is the only error case
Hello and thanks for your fix. Any specific reason you didn't apply this
also in function stmpe_read_temp?
Philippe
>
> Fixes: e813dde6f833 ("iio: stmpe-adc: Use
> wait_for_completion_timeout")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> drivers/iio/adc/stmpe-adc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/adc/stmpe-adc.c b/drivers/iio/adc/stmpe-adc.c
> index d2d405388499..d475d1c17bfc 100644
> --- a/drivers/iio/adc/stmpe-adc.c
> +++ b/drivers/iio/adc/stmpe-adc.c
> @@ -61,7 +61,7 @@ struct stmpe_adc {
> static int stmpe_read_voltage(struct stmpe_adc *info,
> struct iio_chan_spec const *chan, int *val)
> {
> - long ret;
> + unsigned long ret;
>
> mutex_lock(&info->lock);
>
> @@ -79,7 +79,7 @@ static int stmpe_read_voltage(struct stmpe_adc
> *info,
>
> ret = wait_for_completion_timeout(&info->completion,
> STMPE_ADC_TIMEOUT);
>
> - if (ret <= 0) {
> + if (ret == 0) {
> stmpe_reg_write(info->stmpe, STMPE_REG_ADC_INT_STA,
> STMPE_ADC_CH(info->channel));
> mutex_unlock(&info->lock);
next prev parent reply other threads:[~2022-04-11 12:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 10:30 [PATCH] iio: stmpe-adc: Fix wait_for_completion_timeout return value check Miaoqian Lin
2022-04-11 12:05 ` Philippe Schenker [this message]
2022-04-11 14:04 ` Miaoqian Lin
2022-04-12 1:55 ` [PATCH v2] " Miaoqian Lin
2022-04-12 6:29 ` Sa, Nuno
2022-04-12 6:51 ` [PATCH v3] iio: adc: " Miaoqian Lin
2022-04-12 8:52 ` Philippe Schenker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b40cdebc07ff7ca29aa9fc03b8d9c40754ab4bd.camel@toradex.com \
--to=philippe.schenker@toradex.com \
--cc=alexandre.torgue@foss.st.com \
--cc=jic23@kernel.org \
--cc=keescook@chromium.org \
--cc=lars@metafoo.de \
--cc=linmq006@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).