From: Robin Murphy <robin.murphy@arm.com>
To: Vivek Gautam <vivek.gautam@codeaurora.org>,
joro@8bytes.org, robh+dt@kernel.org,
iommu@lists.linux-foundation.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: mark.rutland@arm.com, will.deacon@arm.com, robdclark@gmail.com,
tfiga@chromium.org, sricharan@codeaurora.org,
m.szyprowski@samsung.com, architt@codeaurora.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v9 4/5] iommu/arm-smmu: Add the device_link between masters and smmu
Date: Wed, 14 Mar 2018 17:50:42 +0000 [thread overview]
Message-ID: <8b427ea2-5c13-4712-13d1-e4c1aed0779e@arm.com> (raw)
In-Reply-To: <20180313085534.11650-5-vivek.gautam@codeaurora.org>
On 13/03/18 08:55, Vivek Gautam wrote:
> From: Sricharan R <sricharan@codeaurora.org>
>
> Finally add the device link between the master device and
> smmu, so that the smmu gets runtime enabled/disabled only when the
> master needs it. This is done from add_device callback which gets
> called once when the master is added to the smmu.
>
> Signed-off-by: Sricharan R <sricharan@codeaurora.org>
> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
> Reviewed-by: Tomasz Figa <tfiga@chromium.org>
> ---
> drivers/iommu/arm-smmu.c | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
> index 56a04ae80bf3..64953ff2281f 100644
> --- a/drivers/iommu/arm-smmu.c
> +++ b/drivers/iommu/arm-smmu.c
> @@ -1460,10 +1460,31 @@ static int arm_smmu_add_device(struct device *dev)
>
> iommu_device_link(&smmu->iommu, dev);
>
> + if (pm_runtime_enabled(smmu->dev)) {
> + struct device_link *link;
> +
> + /*
> + * Establish the link between smmu and master, so that the
> + * smmu gets runtime enabled/disabled as per the master's
> + * needs.
> + */
> + link = device_link_add(dev, smmu->dev, DL_FLAG_PM_RUNTIME);
> + if (!link) {
FWIW, given that we don't really care about link itself, I'd be quite
happy to simplify that lot down to:
if (pm_runtime_enabled(smmu_dev) &&
!device_link_add(dev, smmu->dev, DL_FLAG_PM_RUNTIME)) {
> + dev_warn(smmu->dev,
> + "Unable to add link to the consumer %s\n",
> + dev_name(dev));
(side note: since device_link_add() already prints a message on success,
maybe it could print its own failure message too?)
Robin.
> + ret = -ENODEV;
> + goto out_unlink;
> + }
> + }
> +
> arm_smmu_rpm_put(smmu);
>
> return 0;
>
> +out_unlink:
> + iommu_device_unlink(&smmu->iommu, dev);
> + arm_smmu_master_free_smes(fwspec);
> out_rpm_put:
> arm_smmu_rpm_put(smmu);
> out_cfg_free:
> @@ -1486,6 +1507,14 @@ static void arm_smmu_remove_device(struct device *dev)
> cfg = fwspec->iommu_priv;
> smmu = cfg->smmu;
>
> + if (pm_runtime_enabled(smmu->dev)) {
> + struct device_link *link;
> +
> + link = device_link_find(dev, smmu->dev);
> + if (link)
> + device_link_del(link);
> + }
> +
> ret = arm_smmu_rpm_get(smmu);
> if (ret < 0)
> return;
>
next prev parent reply other threads:[~2018-03-14 17:51 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 8:55 [PATCH v9 0/5] iommu/arm-smmu: Add runtime pm/sleep support Vivek Gautam
2018-03-13 8:55 ` [PATCH v9 1/5] driver core: Find an existing link between two devices Vivek Gautam
2018-03-13 9:40 ` Rafael J. Wysocki
2018-03-13 9:55 ` Vivek Gautam
2018-03-13 12:49 ` Robin Murphy
2018-03-13 14:39 ` Vivek Gautam
2018-03-13 9:58 ` Vivek Gautam
2018-03-13 10:15 ` Tomasz Figa
2018-03-13 10:34 ` Vivek Gautam
2018-03-13 11:23 ` Tomasz Figa
2018-03-14 11:12 ` Rafael J. Wysocki
2018-03-14 11:50 ` Tomasz Figa
2018-03-14 11:57 ` Rafael J. Wysocki
2018-03-14 12:14 ` Robin Murphy
2018-03-14 12:27 ` Lukas Wunner
2018-03-20 7:56 ` Vivek Gautam
2018-03-14 12:23 ` Lukas Wunner
2018-03-13 8:55 ` [PATCH v9 2/5] iommu/arm-smmu: Add pm_runtime/sleep ops Vivek Gautam
2018-03-13 8:55 ` [PATCH v9 3/5] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device Vivek Gautam
2018-03-14 17:46 ` Robin Murphy
2018-03-15 7:17 ` Tomasz Figa
2018-03-20 9:49 ` Vivek Gautam
2018-03-13 8:55 ` [PATCH v9 4/5] iommu/arm-smmu: Add the device_link between masters and smmu Vivek Gautam
2018-03-14 17:50 ` Robin Murphy [this message]
2018-03-15 6:18 ` Tomasz Figa
2018-03-15 10:44 ` Robin Murphy
2018-03-15 8:57 ` Vivek Gautam
2018-03-15 11:12 ` Robin Murphy
2018-03-13 8:55 ` [PATCH v9 5/5] iommu/arm-smmu: Add support for qcom,smmu-v2 variant Vivek Gautam
[not found] ` <61d30fff-1bf8-d2c1-bbe9-f93de836ae77@huawei.com>
[not found] ` <7d5af071-ef98-8461-3ce9-e84fc0b3956a@codeaurora.org>
2018-03-28 6:11 ` Yisheng Xie
2018-04-10 13:14 ` Tomasz Figa
2018-04-11 1:22 ` Yisheng Xie
2018-04-11 5:15 ` Vivek Gautam
2018-04-12 1:55 ` Yisheng Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b427ea2-5c13-4712-13d1-e4c1aed0779e@arm.com \
--to=robin.murphy@arm.com \
--cc=architt@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sricharan@codeaurora.org \
--cc=tfiga@chromium.org \
--cc=vivek.gautam@codeaurora.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).