linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: kernel test robot <xiaolong.ye@intel.com>
Cc: Dave Chinner <david@fromorbit.com>,
	Brian Foster <bfoster@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	lkp@01.org
Subject: Re: [lkp] [xfs] a08ee40a79: kmsg.XFS(vdd):unknown_mount_option[nosuchopt]
Date: Mon, 16 May 2016 10:46:04 -0500	[thread overview]
Message-ID: <8b490c2a-505d-bba2-c4a9-b85732505dc5@sandeen.net> (raw)
In-Reply-To: <20160516014233.GA18460@yexl-desktop>

On 5/15/16 8:42 PM, kernel test robot wrote:
> FYI, we noticed the following commit:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> commit a08ee40a79653d082911cab9fbeff94baa7714cb ("xfs: sanitize remount options")
> 
> on test machine: vm-kbuild-4G: 4 threads qemu-system-x86_64 -enable-kvm -cpu qemu64,+ssse3 with 4G memory
> 
> caused below changes:
> 
> 
> [  666.729855] XFS (vdd): unknown mount option [nosuchopt].

This is expected, it's just that we're catching invalid remount options, now,
and being a bit noiser about it.

                default:
                        xfs_warn(mp, "unknown mount option [%s].", p);
                        return -EINVAL;

>From tests/generic/082 :

# first remount ro with a bad option, a failed remount ro should not disable
# quota, but currently xfs doesn't fail in this case, the unknown option is
# just ignored, but quota is still on. This may change in future, let's
# re-consider the case then.
_scratch_mount "-o remount,ro,nosuchopt" >>$seqres.full 2>&1

so the test is intentionally passing in a bad mount option, and the kernel
is just letting us know.

Thanks,
-Eric

      reply	other threads:[~2016-05-16 15:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-16  1:42 [lkp] [xfs] a08ee40a79: kmsg.XFS(vdd):unknown_mount_option[nosuchopt] kernel test robot
2016-05-16 15:46 ` Eric Sandeen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b490c2a-505d-bba2-c4a9-b85732505dc5@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=bfoster@redhat.com \
    --cc=david@fromorbit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@01.org \
    --cc=xiaolong.ye@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).