From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF9B1C4321E for ; Mon, 10 Sep 2018 17:04:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8B27920881 for ; Mon, 10 Sep 2018 17:04:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="pOSRMp1a" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B27920881 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728865AbeIJV7q (ORCPT ); Mon, 10 Sep 2018 17:59:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:38612 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726603AbeIJV7q (ORCPT ); Mon, 10 Sep 2018 17:59:46 -0400 Received: from [10.80.45.152] (unknown [71.69.156.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 58D7F20870; Mon, 10 Sep 2018 17:04:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1536599084; bh=N+EEacqEEELSP1Gnq26pwICuSfOyvsNgWH3ybRXdF0o=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=pOSRMp1an1OAwlc98JwWqdgcKrGCfOV/SByGlentQHMkqvMcPnGkgOr7ivErOU0lG YApOAbiFgsXL/AeChS9u5N/zV2hlfCrpo3pM6mofOnbHWX60fQcHBEXqBFV7QAvhGm X7IOeQJpTKqlsK2dDA/tNhg9qZJbPK/rps2dcBuU= Subject: Re: [Xen-devel] [PATCH V3 1/2] Drivers/PCI: Export pcie_has_flr() interface To: =?UTF-8?B?UGFzaSBLw6Rya2vDpGluZW4=?= Cc: Christoph Hellwig , Bjorn Helgaas , jgross@suse.com, Sinan Kaya , Govinda Tatti , Herbert Xu , Satanand Burla , linux-pci@vger.kernel.org, Felix Manlunas , linux-kernel@vger.kernel.org, Derek Chickles , Srikanth Jampala , JBeulich@suse.com, Russell Currey , bhelgaas@google.com, xen-devel@lists.xenproject.org, boris.ostrovsky@Oracle.COM, Raghu Vatsavayi , roger.pau@citrix.com References: <20171208202424.GC12367@bhelgaas-glaptop.roam.corp.google.com> <426eeeab-0dcd-8de3-9c5f-a166acf2c130@Oracle.COM> <20171212005919.GB30595@bhelgaas-glaptop.roam.corp.google.com> <49956aaf-5fd5-939d-5fc7-231ffdb98b70@Oracle.COM> <20171213212420.GH30595@bhelgaas-glaptop.roam.corp.google.com> <20171215181801.GU30595@bhelgaas-glaptop.roam.corp.google.com> <20171218122629.GA18423@infradead.org> <20180909185944.GC18222@reaktio.net> <9ffe43d2-a44b-974c-85c9-9923d71c5dba@kernel.org> <20180910095231.GD18222@reaktio.net> From: Sinan Kaya Message-ID: <8b56c803-f8b7-2bb3-79b5-c7aebda6c87c@kernel.org> Date: Mon, 10 Sep 2018 13:04:39 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180910095231.GD18222@reaktio.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/10/2018 5:52 AM, Pasi Kärkkäinen wrote: > Hi, > > On Sun, Sep 09, 2018 at 10:33:02PM -0400, Sinan Kaya wrote: >> On 9/9/2018 2:59 PM, Pasi Kärkkäinen wrote: >>> I noticed pcie_has_flr() has been recently exported in upstream Linux: >>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2d2917f7747805a1f4188672f308d82a8ba01700 >>> >>> Are there more changes / cleanups planned to these interfaces, as mentioned last year? >>> >>> (context: xen-pciback reset/do_flr features upstreaming, which kind of stalled last year when pcie_has_flr() wasn't exported at the time) >> >> Exporting pcie_has_flr() is a very simple change which could have been done >> by the XEN porting effort. >> >> Maybe, the right question is what is so special about XEN reset? >> >> What feature PCI core is missing to support XEN FLR reset that caused >> the effort to stall? >> > > Well one of the reasons probably was because Christoph was planning to deprecate the pcie_has_flr() functionality.. > > https://lists.xen.org/archives/html/xen-devel/2017-12/msg01057.html > https://lists.xen.org/archives/html/xen-devel/2017-12/msg01252.html > > But now that pcie_has_flr() is exported and available I guess it's fine to continue using it also for xen-pciback :) > Yeah, I would go ahead with the implementation. Refactoring can be done independently. > > Thanks, > > -- Pasi > >