Re: [PATCH v3] bluetooth: hci_bcm: enable IRQ capability from node

[Nicolas Saenz Julienne <nsaenzjulienne@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 1277 bytes --]

> > > > diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
> > > > index f8f5c593a05c..9f52d57c56de 100644
> > > > --- a/drivers/bluetooth/hci_bcm.c
> > > > +++ b/drivers/bluetooth/hci_bcm.c
> > > > @@ -1409,6 +1409,7 @@ static int bcm_serdev_probe(struct serdev_device
> > > > *serdev)
> > > > {
> > > > 	struct bcm_device *bcmdev;
> > > > 	const struct bcm_device_data *data;
> > > > +	struct platform_device *pdev;
> > > > 	int err;
> > > > 
> > > > 	bcmdev = devm_kzalloc(&serdev->dev, sizeof(*bcmdev),
> > > > GFP_KERNEL);
> > > > @@ -1421,6 +1422,8 @@ static int bcm_serdev_probe(struct serdev_device
> > > > *serdev)
> > > > #endif
> > > > 	bcmdev->serdev_hu.serdev = serdev;
> > > > 	serdev_device_set_drvdata(serdev, bcmdev);
> > > > +	pdev = to_platform_device(bcmdev->dev);
> > > Ultimately bcmdev->dev here comes from a serdev device not a platform
> > > device,
> > > right?
> > I was afraid of this, but then nobody spoke up. Can we fix this or should I
> > just revert the patch?
> 
> sorry about that, i will provide a fix as soon as possible but i have no pi4
> to validate on it so i will add no in cc nicolas and if you can give me a
> feedback i will appreciate .

Thanks, I will :)

Regards,
Nicolas


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]