From: Florian Fainelli <f.fainelli@gmail.com>
To: Dejin Zheng <zhengdejin5@gmail.com>,
davem@davemloft.net, swboyd@chromium.org, ynezz@true.cz,
netdev@vger.kernel.org, jonathan.richardson@broadcom.com
Cc: linux-kernel@vger.kernel.org,
Scott Branden <scott.branden@broadcom.com>,
Ray Jui <ray.jui@broadcom.com>
Subject: Re: [PATCH net v1] net: broadcom: fix a mistake about ioremap resource
Date: Mon, 4 May 2020 20:28:52 -0700 [thread overview]
Message-ID: <8b71b3ba-edc8-ce78-27ba-ce05230efc31@gmail.com> (raw)
In-Reply-To: <20200505020329.31638-1-zhengdejin5@gmail.com>
On 5/4/2020 7:03 PM, Dejin Zheng wrote:
> Commit d7a5502b0bb8b ("net: broadcom: convert to
> devm_platform_ioremap_resource_byname()") will broke this driver.
> idm_base and nicpm_base were optional, after this change, they are
> mandatory. it will probe fails with -22 when the dtb doesn't have them
> defined. so revert part of this commit and make idm_base and nicpm_base
> as optional.
>
> Fixes: d7a5502b0bb8bde ("net: broadcom: convert to devm_platform_ioremap_resource_byname()")
> Reported-by: Jonathan Richardson <jonathan.richardson@broadcom.com>
> Cc: Scott Branden <scott.branden@broadcom.com>
> Cc: Ray Jui <ray.jui@broadcom.com>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: David S. Miller <davem@davemloft.net>
> Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2020-05-05 3:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 2:03 [PATCH net v1] net: broadcom: fix a mistake about ioremap resource Dejin Zheng
2020-05-05 3:28 ` Florian Fainelli [this message]
2020-05-05 6:49 ` Dejin Zheng
2020-05-05 18:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b71b3ba-edc8-ce78-27ba-ce05230efc31@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=jonathan.richardson@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ray.jui@broadcom.com \
--cc=scott.branden@broadcom.com \
--cc=swboyd@chromium.org \
--cc=ynezz@true.cz \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).