From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A36BC2B9F4 for ; Mon, 28 Jun 2021 08:11:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 56C0560724 for ; Mon, 28 Jun 2021 08:11:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232349AbhF1IOP (ORCPT ); Mon, 28 Jun 2021 04:14:15 -0400 Received: from mga09.intel.com ([134.134.136.24]:60152 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232317AbhF1IOD (ORCPT ); Mon, 28 Jun 2021 04:14:03 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10028"; a="207851469" X-IronPort-AV: E=Sophos;i="5.83,305,1616482800"; d="scan'208";a="207851469" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2021 01:11:31 -0700 X-IronPort-AV: E=Sophos;i="5.83,305,1616482800"; d="scan'208";a="456227756" Received: from abaydur-mobl1.ccr.corp.intel.com (HELO [10.249.227.26]) ([10.249.227.26]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2021 01:11:28 -0700 Subject: Re: [PATCH v7 00/20] Introduce threaded trace streaming for basic perf record operation To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Jiri Olsa , Alexander Shishkin , Peter Zijlstra , Ingo Molnar , linux-kernel , Andi Kleen , Adrian Hunter , Alexander Antonov , Alexei Budankov , Riccardo Mancini References: From: "Bayduraev, Alexey V" Organization: Intel Corporation Message-ID: <8b738198-c77e-e35e-2bc8-f709d8ec937f@linux.intel.com> Date: Mon, 28 Jun 2021 11:11:26 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On 27.06.2021 3:46, Namhyung Kim wrote: > Hello, > > On Tue, Jun 22, 2021 at 1:42 AM Alexey Bayduraev > wrote: >> >> Changes in v7: >> - fixed possible crash after out_free_threads label >> - added missing pthread_attr_destroy() call >> - added check of correctness of user masks >> - fixed zsts_data finalization >> [SNIP] > Thanks for your work, mostly looks good now. > > I have a question, where are the synthesized records saved? > Is it the data.0 file? Thanks for the review. As I understand the synthesized records (as well as other user-space records) are saved to perf.data/data, kernel records are saved to perf.data/data. Regards, Alexey > > Thanks, > Namhyung > > >> >> tools/include/linux/bitmap.h | 11 + >> tools/lib/api/fd/array.c | 17 + >> tools/lib/api/fd/array.h | 1 + >> tools/lib/bitmap.c | 14 + >> tools/perf/Documentation/perf-record.txt | 30 + >> tools/perf/builtin-inject.c | 3 +- >> tools/perf/builtin-record.c | 1094 ++++++++++++++++++++-- >> tools/perf/util/evlist.c | 16 + >> tools/perf/util/evlist.h | 1 + >> tools/perf/util/mmap.c | 6 + >> tools/perf/util/mmap.h | 6 + >> tools/perf/util/ordered-events.h | 1 + >> tools/perf/util/record.h | 2 + >> tools/perf/util/session.c | 500 +++++++--- >> tools/perf/util/session.h | 5 + >> tools/perf/util/tool.h | 3 +- >> 16 files changed, 1508 insertions(+), 202 deletions(-) >> >> -- >> 2.19.0 >>