From: Kirill Marinushkin <k.marinushkin@gmail.com>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] ASoC: topology: Add defines for snd_soc_tplg_hw_config.clock_gated
Date: Tue, 20 Feb 2018 18:03:55 +0100 [thread overview]
Message-ID: <8b752929-1e20-b654-514a-fccec1f9fe5c@gmail.com> (raw)
In-Reply-To: <20180219203636.3692-1-k.marinushkin@gmail.com>
On 02/19/18 21:36, Kirill Marinushkin wrote:
> In kernel `soc-dai.h`, DAI clock gating is defined as following:
>
> ~~~~
> \#define SND_SOC_DAIFMT_CONT (1 << 4) /* continuous clock */
> \#define SND_SOC_DAIFMT_GATED (0 << 4) /* clock is gated */
> ~~~~
>
> The corresponding field of struct snd_soc_tplg_hw_config cannot be used as
> bool values due to the inverted logic. Therefore this commit adds the
> defines for this field.
>
> snd_soc_tplg_hw_config.clock_gated = 0 => no effect
> snd_soc_tplg_hw_config.clock_gated = 1 => SND_SOC_DAIFMT_GATED
> snd_soc_tplg_hw_config.clock_gated = 2 => SND_SOC_DAIFMT_CONT
>
> Signed-off-by: Kirill Marinushkin <k.marinushkin@gmail.com>
> Cc: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Takashi Iwai <tiwai@suse.com>
> Cc: alsa-devel@alsa-project.org
> Cc: linux-kernel@vger.kernel.org
> ---
> include/uapi/sound/asoc.h | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/sound/asoc.h b/include/uapi/sound/asoc.h
> index 69c37ecbff7e..86d0599a6f13 100644
> --- a/include/uapi/sound/asoc.h
> +++ b/include/uapi/sound/asoc.h
> @@ -139,6 +139,11 @@
> #define SND_SOC_TPLG_DAI_FLGBIT_SYMMETRIC_CHANNELS (1 << 1)
> #define SND_SOC_TPLG_DAI_FLGBIT_SYMMETRIC_SAMPLEBITS (1 << 2)
>
> +/* DAI clock gating */
> +#define SND_SOC_TPLG_DAI_CLK_GATE_UNDEFINED 0
> +#define SND_SOC_TPLG_DAI_CLK_GATE_GATED 1
> +#define SND_SOC_TPLG_DAI_CLK_GATE_CONT 2
> +
> /* DAI physical PCM data formats.
> * Add new formats to the end of the list.
> */
> @@ -312,7 +317,7 @@ struct snd_soc_tplg_hw_config {
> __le32 size; /* in bytes of this structure */
> __le32 id; /* unique ID - - used to match */
> __le32 fmt; /* SND_SOC_DAI_FORMAT_ format value */
> - __u8 clock_gated; /* 1 if clock can be gated to save power */
> + __u8 clock_gated; /* SND_SOC_TPLG_DAI_CLK_GATE_ value */
> __u8 invert_bclk; /* 1 for inverted BCLK, 0 for normal */
> __u8 invert_fsync; /* 1 for inverted frame clock, 0 for normal */
> __u8 bclk_master; /* 1 for master of BCLK, 0 for slave */
This patch is part 1 of 2. I failed to send both of them as a single patch series.
I will resend them properly in a new thread.
Best Regards,
Kirill
prev parent reply other threads:[~2018-02-20 17:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 6:05 [PATCH 1/2] ASoC: topology: Rename clock_gated to clock_cont in snd_soc_tplg_hw_config Kirill Marinushkin
2018-02-19 6:05 ` [PATCH 2/2] ASoC: topology: Add missing clock gating parameter when parsing hw_configs Kirill Marinushkin
2018-02-20 17:07 ` Kirill Marinushkin
2018-02-19 6:47 ` [PATCH 1/2] ASoC: topology: Rename clock_gated to clock_cont in snd_soc_tplg_hw_config Takashi Sakamoto
2018-02-19 19:00 ` Kirill Marinushkin
2018-02-19 20:36 ` [PATCH v2 1/2] ASoC: topology: Add defines for snd_soc_tplg_hw_config.clock_gated Kirill Marinushkin
2018-02-19 20:36 ` [PATCH v2 2/2] ASoC: topology: Add missing clock gating parameter when parsing hw_configs Kirill Marinushkin
2018-02-20 12:09 ` Applied "ASoC: topology: Add missing clock gating parameter when parsing hw_configs" to the asoc tree Mark Brown
2018-02-20 13:45 ` Mark Brown
2018-02-20 16:56 ` Kirill Marinushkin
2018-02-20 17:03 ` Kirill Marinushkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b752929-1e20-b654-514a-fccec1f9fe5c@gmail.com \
--to=k.marinushkin@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=o-takashi@sakamocchi.jp \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).