From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Hyungwoo Yang <hyungwoo.yang@intel.com>
Cc: linux-kernel@vger.kernel.org, rushikesh.s.kadam@intel.com,
jettrink@chromium.org
Subject: Re: [PATCH] platform/chrome: fix crash during suspend
Date: Fri, 31 May 2019 12:21:38 +0200 [thread overview]
Message-ID: <8b7a8d63-d9e4-6a9e-1b13-423441416c8a@collabora.com> (raw)
In-Reply-To: <1559189034-11268-1-git-send-email-hyungwoo.yang@intel.com>
Hi,
Many thanks for this patch
On 30/5/19 6:03, Hyungwoo Yang wrote:
> Kernel crashes during suspend due to wrong conversion in
> suspend and resume functions.
>
> Use the proper helper to get ishtp_cl_device instance.
>
> Signed-off-by: Hyungwoo Yang <hyungwoo.yang@intel.com>
> ---
> drivers/platform/chrome/cros_ec_ishtp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_ishtp.c b/drivers/platform/chrome/cros_ec_ishtp.c
> index e504d25..430731c 100644
> --- a/drivers/platform/chrome/cros_ec_ishtp.c
> +++ b/drivers/platform/chrome/cros_ec_ishtp.c
> @@ -707,7 +707,7 @@ static int cros_ec_ishtp_reset(struct ishtp_cl_device *cl_device)
> */
> static int __maybe_unused cros_ec_ishtp_suspend(struct device *device)
> {
> - struct ishtp_cl_device *cl_device = dev_get_drvdata(device);
> + struct ishtp_cl_device *cl_device = ishtp_dev_to_cl_device(device);
> struct ishtp_cl *cros_ish_cl = ishtp_get_drvdata(cl_device);
> struct ishtp_cl_data *client_data = ishtp_get_client_data(cros_ish_cl);
>
> @@ -722,7 +722,7 @@ static int __maybe_unused cros_ec_ishtp_suspend(struct device *device)
> */
> static int __maybe_unused cros_ec_ishtp_resume(struct device *device)
> {
> - struct ishtp_cl_device *cl_device = dev_get_drvdata(device);
> + struct ishtp_cl_device *cl_device = ishtp_dev_to_cl_device(device);
> struct ishtp_cl *cros_ish_cl = ishtp_get_drvdata(cl_device);
> struct ishtp_cl_data *client_data = ishtp_get_client_data(cros_ish_cl);
>
>
As this patch is a fix for '26a14267aff2 platform/chrome: Add ChromeOS EC ISHTP
driver' which is still for-next material, do you mind if I squash both patches?
If you don't mind I'll add your Signed-off and a small comment saying that you
fixed this.
Thanks,
Enric
next prev parent reply other threads:[~2019-05-31 10:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 4:03 [PATCH] platform/chrome: fix crash during suspend Hyungwoo Yang
2019-05-31 10:21 ` Enric Balletbo i Serra [this message]
2019-05-31 18:15 ` Yang, Hyungwoo
2019-06-04 15:03 ` Enric Balletbo i Serra
2019-06-04 16:17 ` Yang, Hyungwoo
2019-07-29 11:29 ` Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b7a8d63-d9e4-6a9e-1b13-423441416c8a@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=hyungwoo.yang@intel.com \
--cc=jettrink@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rushikesh.s.kadam@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).