linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Wang Junqiang <wangjunqiang@iscas.ac.cn>, guoren@kernel.org
Cc: guoren@linux.alibaba.com, linux-csky@vger.kernel.org,
	linux-kernel@vger.kernel.org, Li Weiwei <liweiwei@iscas.ac.cn>
Subject: Re: [PATCH 2/2] csky: add CONFIG_CPU_HAS_MATHEMU and use in traps
Date: Tue, 20 Apr 2021 20:01:19 -0700	[thread overview]
Message-ID: <8bb2a70f-7f3a-26f1-98ed-e6b7b2220798@infradead.org> (raw)
In-Reply-To: <20210421024916.13603-1-wangjunqiang@iscas.ac.cn>

Hi--

On 4/20/21 7:49 PM, Wang Junqiang wrote:
> diff --git a/arch/csky/Kconfig b/arch/csky/Kconfig
> index 34e91224adc3..a414225570c1 100644
> --- a/arch/csky/Kconfig
> +++ b/arch/csky/Kconfig
> @@ -97,6 +97,9 @@ config CPU_HAS_CACHEV2
>  config CPU_HAS_FPUV2
>  	bool
>  
> +config CPU_HAS_MATHEMU
> +	bool
> +

Why do you have this new kconfig symbol two times in the same file?

>  config CPU_HAS_HILO
>  	bool
>  
> @@ -281,6 +284,11 @@ config CPU_HAS_VDSP
>  	bool "CPU has VDSP coprocessor"
>  	depends on CPU_HAS_FPU && CPU_HAS_FPUV2
>  
> +config CPU_HAS_MATHEMU
> +	bool "CPU has FPU Mathemu Instructions"
> +	depends on CPU_CK810 || CPU_CK860
> +	default n
> +
>  config CPU_HAS_FPU
>  	bool "CPU has FPU coprocessor"
>  	depends on CPU_CK807 || CPU_CK810 || CPU_CK860


thanks.
-- 
~Randy


  reply	other threads:[~2021-04-21  3:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-21  2:49 [PATCH 2/2] csky: add CONFIG_CPU_HAS_MATHEMU and use in traps Wang Junqiang
2021-04-21  3:01 ` Randy Dunlap [this message]
2021-04-21  3:08   ` 王俊强
2021-04-21 22:46 ` kernel test robot
2021-04-27 15:02 ` Guo Ren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bb2a70f-7f3a-26f1-98ed-e6b7b2220798@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=guoren@kernel.org \
    --cc=guoren@linux.alibaba.com \
    --cc=linux-csky@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liweiwei@iscas.ac.cn \
    --cc=wangjunqiang@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).