From: Javier Martinez Canillas <javierm@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: "Jani Nikula" <jani.nikula@intel.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Peter Robinson" <pbrobinson@gmail.com>,
"Michel Dänzer" <michel@daenzer.net>,
dri-devel@lists.freedesktop.org,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Pekka Paalanen" <pekka.paalanen@collabora.com>
Subject: Re: [PATCH v5 0/6] Cleanups for the nomodeset kernel command line parameter logic
Date: Sat, 27 Nov 2021 14:06:38 +0100 [thread overview]
Message-ID: <8bc41099-9063-94d0-1a5a-a06c265497e4@redhat.com> (raw)
In-Reply-To: <20211112133230.1595307-1-javierm@redhat.com>
On 11/12/21 14:32, Javier Martinez Canillas wrote:
> There is a lot of historical baggage on this parameter. It is defined in
> the vgacon driver as nomodeset, but its set function is called text_mode()
> and the value queried with a function named vgacon_text_force().
>
> All this implies that it's about forcing text mode for VGA, yet it is not
> used in neither vgacon nor other console driver. The only users for these
> are DRM drivers, that check for the vgacon_text_force() return value to
> determine whether the driver should be loaded or not.
>
> That makes it quite confusing to read the code, because the variables and
> function names don't reflect what they actually do and also are not in the
> same subsystem as the drivers that make use of them.
>
> This patch-set attempts to cleanup the code by moving the nomodseset param
> to the DRM subsystem and do some renaming to make their intention clearer.
>
I have pushed these patches to the drm-misc-next branch.
Thanks a lot everyone for the help with this series!
Best regards,
--
Javier Martinez Canillas
Linux Engineering
Red Hat
prev parent reply other threads:[~2021-11-27 13:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 13:32 [PATCH v5 0/6] Cleanups for the nomodeset kernel command line parameter logic Javier Martinez Canillas
2021-11-12 13:32 ` [PATCH v5 1/6] drm: Don't print messages if drivers are disabled due nomodeset Javier Martinez Canillas
2021-11-12 13:32 ` [PATCH v5 2/6] drm/vboxvideo: Drop CONFIG_VGA_CONSOLE guard to call vgacon_text_force() Javier Martinez Canillas
2021-11-12 13:32 ` [PATCH v5 3/6] drm: Move nomodeset kernel parameter to the DRM subsystem Javier Martinez Canillas
2021-11-19 10:20 ` Javier Martinez Canillas
2021-11-19 11:08 ` Greg Kroah-Hartman
2021-11-12 13:32 ` [PATCH v5 4/6] drm: Decouple nomodeset from CONFIG_VGA_CONSOLE Javier Martinez Canillas
2021-11-12 14:05 ` Jani Nikula
2021-11-12 13:32 ` [PATCH v5 5/6] Documentation/admin-guide: Document nomodeset kernel parameter Javier Martinez Canillas
2021-11-12 13:32 ` [PATCH v5 6/6] drm: Make the nomodeset message less sensational Javier Martinez Canillas
2021-11-27 13:06 ` Javier Martinez Canillas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bc41099-9063-94d0-1a5a-a06c265497e4@redhat.com \
--to=javierm@redhat.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michel@daenzer.net \
--cc=pbrobinson@gmail.com \
--cc=pekka.paalanen@collabora.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).