From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941148AbcKPUtu (ORCPT ); Wed, 16 Nov 2016 15:49:50 -0500 Received: from mail-by2nam03on0070.outbound.protection.outlook.com ([104.47.42.70]:61683 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932301AbcKPUtp (ORCPT ); Wed, 16 Nov 2016 15:49:45 -0500 X-Greylist: delayed 12725 seconds by postgrey-1.27 at vger.kernel.org; Wed, 16 Nov 2016 15:49:45 EST Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Janakarajan.Natarajan@amd.com; Subject: Re: [PATCH] Support for perf on AMD family17h processors To: Borislav Petkov References: <1479315713-11115-1-git-send-email-Janakarajan.Natarajan@amd.com> <20161116184726.4rkhsoxx35mr7pdz@pd.tnic> CC: , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , "Suravee Suthikulpanit" From: "Natarajan, Janakarajan" Message-ID: <8bd06d95-1d43-934c-4112-016f1c076585@amd.com> Date: Wed, 16 Nov 2016 14:49:29 -0600 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161116184726.4rkhsoxx35mr7pdz@pd.tnic> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: YQXPR01CA0051.CANPRD01.PROD.OUTLOOK.COM (10.165.103.19) To BN6PR12MB1795.namprd12.prod.outlook.com (10.175.101.144) X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1795;2:f6zfvQ66/xwLh0lf8uIJms7kpkW2WHvjPI5mWNZLnVoc86e3AwHFQ8K2IgU3GzCL7tzA8yH0q6Y5riPM5dQsaSn802VbSLmNiuh/2XMFfrsUl9XZRqJj2iNpqTYXR5TwD8Nog3lTtmwwaipD/hEjCLW9afdpcAnCY9QNXWE2pYM=;3:lvUd2kJFp88WvsfV+DAUs3XKCk23EYZdeg47O3trBriV6TZxrM7xwyCwMdOtSaji+2QjKxTxka//QWLvoTQp4EVgkGxRdEg6fyv9cRbIhgSZDmhAV/hx2nNs0IsuJ+C9WIOszxa5phUSNcBFylO2maXAZ95Os1r0g3nE+H/2hOw= X-MS-Office365-Filtering-Correlation-Id: 677ee4a1-ff3b-4564-1a39-08d40e621428 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BN6PR12MB1795; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1795;25:YPykFRXIEYVuPwgTSxNGfW8XsCWlKJJZBKJJfy8aCTDwwAcqBGFeynj21w4d/X+B5MVuV3xVOL5GvPd64yYvXaxmE7fZxmwzySXYFcB1ylZ+kBITB910TFrmxkubXqyunFauupVf2tIAXUWCJx86EfK7APwsENC+4WJGmzLsUUULf931UlLZf0jbA9QXJDc8OGdvaLpmv8QG2sjBwh2YjtM3/eMHu9Oc9AZ27Q2kubnTl2LZIxVmd+kM5NTVyKOMgmiOaY0V/IiRNWea1B7JyMLaEDYNm/ofzThOgiF0WyMP5r/QlBHFWD/Br/qZYrZlnolh86WKUpiab6EyVjNZOvnztugRXiFetlPG0wDY3W7gGcXH/X+NB0zNnF+JW5P1BjijYyySNd7eg7sN5vFRyaJaXMnsyOtFCnOLtfpDAK+kJBScp1M0qOo/hVOCR++9dA48XJgVcgjVnpD01PcbAGLW5bvFVtLCMVU4sSPMZoiVFHYh/GijcTdSkNv3Ts2ra/n3PxFS8WHJZilIX3DnzXD7v76lQZCJFTiI8TF344smsfQY3nUjRv0gf42aaIhOfbUpRviIUXO56SagHAr/WgEvq9sKkuofxt2HloqKTxYXf2P+9Ffe45nn3LDrg3BWWYh5l7x+/zIfflffZaZmAZjFj5a/X2tXNRHL3DfWa3zA2gv61sqjb+85CHE0N11ew7JN/AJ77KQnR4HH+mxzkMgbGF8jpzlAS6s7HplpYVR/ogHYweoGImzbgkhCFOo2YUK+kz2deZZdowcAaWYd0Q== X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1795;31:ZS5EcQKBiSlG89sT3IaLGIZ3kRDthzyMDX7ehoUpaOXDc9WETJEL7TjQwewhWKKSCJqJ+SVOVF+PP0DNV307r990d+sYxPCEPKU2QBce6+tLG3cKKnpaCb+iEdVlfSKXJ+aQPUh8HYIRjW5Q1r7CSNXsm/DrqhTbDrVNMZDHyTb8pVg2hzi7a9fSojiR2D4zOenuIcnpXhsXSLtrqsoKI0Bha2XCPRsy6Xjg+KwcYDczWMpx6BzOdsjG3wJUFjzGul401B63dbiQCgzaeaZxvA==;20:QjF47BHbVzDPI+5uxydSYmQHflxQVZOITZXqHpycIuohJ6DLfwhR6qb4CW6iL56Ftu4M8xFwLRqi0ERtYr7qr4U9mLcOBAkJdU250qDOaqRmtAPkxGRHc32G/Q4WufjlXAUz7RfFs0QpxdcOsN8OWyEpx0+0dkVTk1Ru8V3gemEr3xfv7SBqtWlGeu0q7NlufyHjDu9C53kfHsf1iGLJ1efY9F1T+7PS8Vp38MozwXb9T8CoTRw3E4C0qqazPWXET866Bs3H5AMvcV/9zXOhj5I+3uKdBdjc18W8f8n56S7NC7p7Lm/EsPvi1VQ+ujQDIM48PpJn6oOiZEurVbRBUlcQuGqVnrujWvnlPssp2rVxmQwN2pLUAd1AlLilUpkH5ehqvTJNDVOiSiiGuuVBjX780A7njnR7kB/sya1HDO0wyLEdKCBBcEv3NDIZq0+y2NopWxCRTZ2xli/0lSEF4QxrP68HoM+Zch1+cX50TqU58fHxoPymfDqGkGcg75xC X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6060326)(6040281)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6061324)(6041223)(6072148);SRVR:BN6PR12MB1795;BCL:0;PCL:0;RULEID:;SRVR:BN6PR12MB1795; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1795;4:ejEVY3yYJPtSHGbJnDUI4ZeVAUdGKOi/+tKVFXGhmuH+RwNSROCFuCFaQ684fQdpoaeEFtIjhCWK21phK1LnTUIXNCE1DhhFMU2uoENHUfgRCFDlNrDPV2w8PCcTCEAoWQRYiiehQiiNw0rXcUljOFZ/pd+9wJSq0Hxe/Blv0PUlC81ICukZ17Y8WWVlIkcsGruhrkoZeBBTiJj93KgCzMf9prKGKttBdJzNC8FQmA9MXgINatU8id+9BmBHznphq1kFJMqpdeqIN4/qTjlNt/Y5uE38Npnk0y88m0blFndAa4Dh2f3fgpk3Ftfrzp6t2zkbilXq0XYB7fovVpDLeHF327Z6Lh8FTKf+IVeXt6depxigq58F6D7TK09ab0KpnN9X3TU0N+MqQkcD3d4l1BYMQJ7yQuU56iaMHZhdKIbNfIQ/1amNR08mPHGy567FdqkNeUh9yB74/McQUHKsOmmbCXKa4nk9z6tY7n90DT2L5fl/CdUpS7cKoho7R6RByo/yicr/LXve2J2zV+ZK7IFeh44HywlpY0FtbV0pHN4= X-Forefront-PRVS: 01283822F8 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(7916002)(189002)(377454003)(199003)(24454002)(229853002)(36756003)(86362001)(42186005)(31686004)(31696002)(81166006)(81156014)(64126003)(106356001)(105586002)(6116002)(3846002)(101416001)(7846002)(76176999)(2950100002)(23676002)(50466002)(305945005)(6666003)(68736007)(7736002)(33646002)(77096005)(110136003)(230700001)(2906002)(54356999)(92566002)(50986999)(6916009)(189998001)(4326007)(4001350100001)(97736004)(65806001)(65826007)(5660300001)(8676002)(83506001)(65956001)(66066001)(47776003);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR12MB1795;H:[10.236.19.193];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjEyTUIxNzk1OzIzOmpLUFh0Nk9RMmNGV2FZanJzMkhGZ1JSQjlz?= =?utf-8?B?MUI2eG1RbXdSQVJaS0QySHlYd24zaFFqQ2FTTmppVmdvZDBmTzVJcHdWN0hn?= =?utf-8?B?czU5VzUwbW5ENHFDZHlGaTVSbUQ2eUlCSjJjQlRYMjhiRnVwZnNKak5CYStG?= =?utf-8?B?YjRFN0xIN3djQldPdkVvdjFmS0o5eS9oRXZXdURibnFjdHJmdHg5NmNoZkJB?= =?utf-8?B?cUppT3psSTFGbFZGMEVwbzZWLzMxS0hLMU4vMFVXMlk2WFRPbTZVbFBFQVVO?= =?utf-8?B?dVJPazEyNmluakh5L3M4Qk5icFp5cjBOVXNEcVBtWkkwSUowbEI0RUdVODZZ?= =?utf-8?B?bEhmUm9HTFM0UWc2OEZnS3g5ZUNYYnFockJLVGdaK2kwV2hLQjBjaWlyZG9J?= =?utf-8?B?ZG51a3VLUVl2SFgrVWhlaXVhWC9XTlFQQ1RqS0hDc1pBTk5IWVlUeVkra0RO?= =?utf-8?B?QldKWk1MN0REeHhDbkx1eGhrQ3hleEZ6d2tHTGx1TU5qNTlTK1I0MnV5KzYx?= =?utf-8?B?NU1DcnFTRjliZDIwVjFsMDZjUVNoQ1Q5QkVZelRCMmFGVDZYWUcxUG0xZDBs?= =?utf-8?B?OEdpMTRkSitBL0h2ZlpwckF5ZURMQTdDMGVYZm1sYk5yeW1HWDFXZVpxRHB6?= =?utf-8?B?dXo0WjJJRm5DQ0svMmFyVGNGZDhxVXBXU0JKYXVrYzQvRG5BeGJodE5wdStJ?= =?utf-8?B?eUl2RTF4Z3NHRUY4WE9LZ3k0djc2b3R2dGowQ1U3Tkx3SDdwYnlOZ1E1cmV1?= =?utf-8?B?em42cXY0Rjc4Mnpnd1RkNVRtbGppbDQzS005bXdiUU5ucTlLc0N2VThDNmVa?= =?utf-8?B?ZjNEWmRDM2pnQlJBbGdpcVhvMjhkWXduN3grbzQrUE9kdFltQXZZLzhkNXRm?= =?utf-8?B?ZTVvY1orem04UmVKYzRtdldCWDlGVUJhRG1JVHZTZE40RmY4UWRubTZkdzQr?= =?utf-8?B?TFUwWnVNZ0JzYjlxSnlJNHZPQWFqWkFXZzVaSU1qOXN3Slo0TUhQQjE4TEZB?= =?utf-8?B?eUZUdzlmMHU5SUQ4eXdieWIzcXJ5d0FDeGorU3BHNHJ6UzBKeEliYTJ1Tlhh?= =?utf-8?B?bVRLRHZZRCszODBzSXFCWGdTc3FOSWZjRVgxdkVCYU5ITEFIb1E5YU1KUjNi?= =?utf-8?B?WEJocVRFS3U2d2c4TmtKN3RwUzBrVFpXT1Y2aGduTTBzby9ldnYxREtTTk43?= =?utf-8?B?YllWclgwdkI0dHBuamo0cE1IVDA4L01pOXJWaS9IMVErVzVOMlRpRlB1Zm9n?= =?utf-8?B?aHpxa25mWEMzNGlXSlNRWUFrenlzK2E3ZUt4SUhUZVZwL1lLWlBXK3ZKakQx?= =?utf-8?B?eDVxWlpqS1FnVGZqL2hPd1dkR0JRc1hJdlNoZU4waW1EM0FndTV5RnpodE1N?= =?utf-8?B?OXlWSkZUeWVMcEhqa3lDTm53T0NZQm81TGIwUHhSUjhLY3ZUR1EvVGQxS1Yr?= =?utf-8?B?bU1RbzBDMGY2VzJhZWZrTUtNSEFlL3FpVTZsVWpFajB2VnpGMFJBZkkrK3RZ?= =?utf-8?B?YlY3MDhqdmYrNXFNV3d2Q3F6TFVBQTRJckxWYkFZV0xQM0VKb05XYUhvM29V?= =?utf-8?B?MFFGVlZJUVIyRjlyejdLSkhnUVdXRFBheThHVjh4Y2FYY3NPTnNoaFl4bWcv?= =?utf-8?B?L3VHU1dUSndneXJ2ODZJSGZ4UVFnSEdXa0VuZjhwZ3V1S1V3Vy82M2JmSmR6?= =?utf-8?B?QytWVThkb2x3MkxXZWZsN2kwYnJTWHlDRjlEYzFDcFY5cGcyNzZ5QWtNMEE3?= =?utf-8?B?cFovdHpJV0h0b3RuWEdGQT09?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1795;6:tg9qpqKhdtbGJgGei3G9AH1Y/1O8pzFObHerxDJcWNUT5kFMuh3hOvulpox51ZsLRM08PyadCZGVHYXk0ZFkH4EZ9uXn0iICQ633U+Z9DCCUP40eI+PneSWk0QHrpjZIlig4ruhqd5WsE0Fr03IQmE0tCv7cQ37+ME8oHG9YY23X60JvG0bzm3uScETghqdimIFWBB6fJrHuWJlzK8f7bRX0TP7UNvQuOAnH4HFMyhLRELts1vpu2yXQVDejKCfU7AU40Y6B+NB0LshLT+DdDj123Em1Te5bpppiviEuL7XIndf7xi2wFA15yQf8KwgL1Qlt/iL2oxOMrEFcZA6Hjr2DOEWn21zpVFo5Pzj3HPjtc8Nj9uPadkdEZ3AK71gD;5:pf4R1HrPRhHshvYPVAa1iAgVYq6X9CuBOh2RFyskG3+AUmNoS9lfl4+J6PBdph43d+OleO0WbgaHwW8ytxeVemir3u+mT7Y2cH23GIAAJLvlJJWLU3Ik8cfdqTdU8zvAoPqxgAvhhqeTT8o14cv2/KCNEIXQGvI3AxU34kHHClY=;24:8XQMX51/3WfcsIEX0v+Fyh3LBqszXBkBdkLGsx97l3IKUPJBFVaztVf7mNygCAU2pcyy1eneqQQLisuAuYEu9Mi4M9mEcOOC7D3HjvGwZfA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1795;7:Rg6xGHh+SRNqtxdLz6fAVvNMKIk/lEwPgS6K/I505qGC9NZSX3kXSPEVt6zZ8exoxrb7rnE98biLLkqXm+Wrr7pHgmRwdSh5yLOzmZAYVXzeIfM/+TAVIye39YA7f+QbaQ4jBP1fnxxBqRkfo2/AzFCGNZRrYo4pbka3f2rBOF1E6az/MPdJQvBojn5+SegiQ5Ssslo9Unxnps5ZO/PK3s1ler/UW/+/bjNPpyVXsuRQZCZuuCFVcf0B+tK/s1V/LXEnnb97YC9+6GRLfk7Na4Wrk/bKiZDJhV97UJtLOtwVQPdpq9kqwHq687k5CVB6lnGfNyJIMslAIdl59eMSiRcXj2ETPS64IDESknAY8hQ=;20:qNEqgo65n3pCFnRfCiq5htt1KcZ/GB+dRIyrcNtMcxiVvW+rW9nYE+agcSZTSTD+JzJSfQBIfEs1vFeTvhEiU+re0AYa5ucCfk8I3X0XllAZczUzGtJ7pZPVgCZgXx/008fFbXaLMOcvTiLDdycjpc4/ownHApzzYlSVz/auNdM24mVjxYXKP1I+fglXUYPA6Bk1kKo0IgU3sPdVZzDKvJD00LPIt+6wtGtXEb8sfXIe2u7rDa9a3PN+BQ9oNpnA X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2016 20:49:36.4831 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1795 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/16/2016 12:47 PM, Borislav Petkov wrote: > On Wed, Nov 16, 2016 at 11:01:53AM -0600, Janakarajan Natarajan wrote: >> This patch enables perf core PMU support for AMD family17h processors. >> In family17h, there is no PMC-event constraint. All events, irrespective >> of the type, can be measured using any of the performance counters. >> >> Signed-off-by: Janakarajan Natarajan >> --- >> arch/x86/events/amd/core.c | 15 ++++++++++++--- >> 1 file changed, 12 insertions(+), 3 deletions(-) >> >> diff --git a/arch/x86/events/amd/core.c b/arch/x86/events/amd/core.c >> index f5f4b3f..849688d 100644 >> --- a/arch/x86/events/amd/core.c >> +++ b/arch/x86/events/amd/core.c >> @@ -652,7 +652,11 @@ static __initconst const struct x86_pmu amd_pmu = { >> .amd_nb_constraints = 1, >> }; >> >> -static int __init amd_core_pmu_init(void) >> +/* >> + * This function initializes core PMU to enable support >> + * for AMD Core PMC Extension. >> + */ >> +static int __init amd_core_pmc_ext_init(void) >> { >> if (!boot_cpu_has(X86_FEATURE_PERFCTR_CORE)) >> return 0; > This renaming looks pretty useless to me. So does the comment. I'll remove the renaming and comment in a v2 patch. >