From: Larry Finger <Larry.Finger@lwfinger.net>
To: David Laight <David.Laight@ACULAB.COM>,
'Aakash Hemadri' <aakashhemadri123@gmail.com>,
Phillip Potter <phil@philpotter.co.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Bjorn Helgaas <bjorn@helgaas.com>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] staging: r8188eu: clean up endianness issues
Date: Fri, 20 Aug 2021 12:13:15 -0500 [thread overview]
Message-ID: <8bd7047c-49d1-b93d-3ccb-96d9773f3f66@lwfinger.net> (raw)
In-Reply-To: <3dfde3cd06094e52b71b48a3a2524226@AcuMS.aculab.com>
On 8/20/21 5:26 AM, David Laight wrote:
> From: Aakash Hemadri
>> Sent: 18 August 2021 16:53
>>
>> Fix these sparse warnings:
>
> Did you test this code before and after the changes?
>
> I think you've changed the behaviour on LE systems which
> are probably the ones it was actually tested on.
>
> Don't blindly change code to fix sparse warnings.
I'm late getting into this conversation. Gmail thought the original patches were
spam.
First of all, we need to change the behavior as the original code is wrong;
however, the code involves PPPoE, which I have never used, and never tested. I
still need to check the correct endian values for one of the packet types. I
hate reading IEEE official documents!!!!
I should have a review of the patches later today.
Larry
prev parent reply other threads:[~2021-08-20 17:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 15:52 [PATCH] staging: r8188eu: clean up endianness issues Aakash Hemadri
2021-08-18 20:40 ` Greg Kroah-Hartman
2021-08-20 10:26 ` David Laight
2021-08-20 17:13 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd7047c-49d1-b93d-3ccb-96d9773f3f66@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=David.Laight@ACULAB.COM \
--cc=aakashhemadri123@gmail.com \
--cc=bjorn@helgaas.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).