linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicolas Dufresne <nicolas@ndufresne.ca>
To: Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	Alexandre Courbot <acourbot@chromium.org>
Cc: Tomasz Figa <tfiga@chromium.org>,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	Dafna Hirschfeld <dafna3@gmail.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Linux Media Mailing List <linux-media@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Boris Brezillon <boris.brezillon@collabora.com>,
	kernel mailing list <kernel@lists.collabora.co.uk>,
	Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@siol.net>,
	Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH v4] media: docs-rst: Document m2m stateless video decoder interface
Date: Mon, 29 Apr 2019 20:47:23 -0400	[thread overview]
Message-ID: <8bfacddaf6c8a94bccbae5c6a83688d42bbf63a9.camel@ndufresne.ca> (raw)
In-Reply-To: <0c8d534cf1ad262ab790f4ccfe9c2900e8a50aba.camel@bootlin.com>

Le lundi 29 avril 2019 à 22:32 +0200, Paul Kocialkowski a écrit :
> > Adding Boris in CC. Boris, do you think that could possibly fit into
> > your todo while working on the H264 accelerator on RK ? If needed I can
> > generate test streams, there is couple of lines of code to remove / add
> > in FFMPEG backend if you want to test this properly, though I'm not
> > able to run this code atm (it requires a working DRM, and I'm having
> > issues with my board in this regard).
> 
> Well, that seems like a task that requires in-depth knowledge about how
> the v4l2 m2m core and the request API work and some familiary with
> it. My feeling is that Boris is pretty new to all of this, so perhaps
> it would be best for him to focus on the rockchip driver alone, which
> is already a significant piece of work on its own.
> 
> It looks like Hans has proposed to come up with something soon, so
> things are looking good for us. Once we have that, I think the next
> area we need to look into is how we need to rework and refine the
> controls. I think it would be good to define common guidelines for
> adapting bitstream descriptions into controls with what the hardware
> needs to know about precisely.
> 
> In spite of that, I would be very interested in knowing what the
> rockchip MPEG-2 and H.264 decoders expect precisely. I'm also

We are still working on that. For now, we believe that the list (and
traces from real stream matches) are according to the standard
"Initialization process" section 8.2.4.2. But they run both P and B
initialization regardless of the type, hence the 3 lists. But the
modification (section 8.4.2.3) are not applied. They also program the 3
lists regardless of the current picture type. This is quite strange.
Tomorrow I'll mark all b0/b1 value as invalid on P slice and the
opposite for B slice to see if that still decodes fine. If that was the
case, it would mean that the current list are complete, but not in the
expected order.

What I'm wondering is if it would be fine to add more information to
the DPB entry so that we could simply implement 8.2.4.2 to re-create
the pre-modification order. It's more doable then trying to reverse the
modifications and would offer a better uAPI in exchange for a very
small overhead.

> interested in learning about Tegra decoders and there are also docs
> about the Hantro G1 (MPEG-2 to H.264) and Hantro G2 (H.265) which are
> well documented in the i.MX8M docs. It's also used on some Atmel
> platforms apparently. So feedback regarding the current controls that
> Maxime and I came up with would be welcome.


  reply	other threads:[~2019-04-30  0:47 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-06  8:00 [PATCH v4] media: docs-rst: Document m2m stateless video decoder interface Alexandre Courbot
2019-04-12 20:47 ` Nicolas Dufresne
2019-04-14 16:41   ` Paul Kocialkowski
2019-04-14 22:38     ` Nicolas Dufresne
2019-04-15  7:58       ` Paul Kocialkowski
2019-04-15 12:24         ` Nicolas Dufresne
2019-04-15 13:26           ` Paul Kocialkowski
2019-04-15 15:30             ` Nicolas Dufresne
2019-04-16  7:22               ` Alexandre Courbot
2019-04-16  7:55                 ` Paul Kocialkowski
2019-04-17  5:39                   ` Alexandre Courbot
2019-04-17 16:09                     ` Nicolas Dufresne
2019-04-17 16:06                 ` Nicolas Dufresne
2019-04-17 17:18                   ` Paul Kocialkowski
2019-04-26 14:18                 ` Hans Verkuil
2019-04-26 16:28                   ` Paul Kocialkowski
2019-04-27 12:23                     ` Nicolas Dufresne
2019-04-27 12:48                       ` Paul Kocialkowski
2019-04-27 12:06                   ` Nicolas Dufresne
2019-04-29  8:41                     ` Hans Verkuil
2019-04-29  8:48                       ` Paul Kocialkowski
2019-04-29  8:49                         ` Hans Verkuil
2019-04-29  8:50                           ` Paul Kocialkowski
2019-04-29 18:27                         ` Nicolas Dufresne
2019-04-29 20:32                           ` Paul Kocialkowski
2019-04-30  0:47                             ` Nicolas Dufresne [this message]
2019-04-16  7:37               ` Paul Kocialkowski
2019-04-17 16:17                 ` Nicolas Dufresne
2019-04-17 17:21                   ` Paul Kocialkowski
2019-04-17 15:30     ` Nicolas Dufresne
2019-04-17 15:40       ` Paul Kocialkowski
2019-04-17 16:22         ` Nicolas Dufresne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bfacddaf6c8a94bccbae5c6a83688d42bbf63a9.camel@ndufresne.ca \
    --to=nicolas@ndufresne.ca \
    --cc=acourbot@chromium.org \
    --cc=boris.brezillon@collabora.com \
    --cc=dafna3@gmail.com \
    --cc=hverkuil@xs4all.nl \
    --cc=jernej.skrabec@siol.net \
    --cc=jonas@kwiboo.se \
    --cc=kernel@lists.collabora.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=maxime.ripard@bootlin.com \
    --cc=mchehab@kernel.org \
    --cc=paul.kocialkowski@bootlin.com \
    --cc=tfiga@chromium.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).