From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55FB6C4338F for ; Thu, 29 Jul 2021 00:40:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3162260E9B for ; Thu, 29 Jul 2021 00:40:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233013AbhG2Ak5 (ORCPT ); Wed, 28 Jul 2021 20:40:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:46114 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232837AbhG2Ak4 (ORCPT ); Wed, 28 Jul 2021 20:40:56 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A843C6103B; Thu, 29 Jul 2021 00:40:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627519254; bh=uNIc7pfoGu/FJThfBBj9+RPriWv7zO4JIA2SEJzetJU=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=OdyQCOsKhEDk9fPkieTeaxQN+hnutClJj5EUNp7HUhg8oXNR3w0AryUxZnQxWrUCv Eq66HIf/Y7hi8i2sG2U3ICf8Bpe08driDJnah557lnpQMWGVZuE+KHQ9YMFLo6iDEo 2rCgB5+H90rEHaH2pdeeM5Sv1NOv1P22K58TWFyJDHgWWGU5Jmr5TH4G+aaXDUGvi/ x1L2gA5CYtYWzK/CA5nXoOoizBq1AabMCzQKmo/AEtd3JNwSiE0PL9T6/lqYk42tZ7 JnYCmWWUokYUJ2Mntn5gPWnPe7BmRQbmv7YQNM16u1Y3fzgbourJ9MXcBulFnWN++0 ZT6jyeNs4HVSQ== Subject: Re: [f2fs-dev] [PATCH v4] f2fs: change fiemap way in printing compression chunk To: Jaegeuk Kim Cc: Daeho Jeong , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com, Daeho Jeong , Eric Biggers References: <20210726041819.2059593-1-daeho43@gmail.com> From: Chao Yu Message-ID: <8c0d05d2-3988-a8a4-5403-1173f25b822b@kernel.org> Date: Thu, 29 Jul 2021 08:40:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/7/28 1:17, Jaegeuk Kim wrote: > Do we really need to catch this in fiemap? What about giving the current Yes, I think so. > layout with warning message and setting NEED_FSCK? Sure, How about doing sanity check on cluster metadata whenever it is going to be accessed, like we did for single blkaddr with f2fs_is_valid_blkaddr()? Thanks,