From: Dmitry Osipenko <digetx@gmail.com>
To: Rob Herring <robh@kernel.org>, David Heidelberg <david@ixit.cz>
Cc: Sebastian Reichel <sre@kernel.org>,
Jonghwa Lee <jonghwa3.lee@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Myungjoo Ham <myungjoo.ham@samsung.com>,
Sumit Semwal <sumit.semwal@linaro.org>,
John Stultz <john.stultz@linaro.org>,
Vinay Simha BN <simhavcs@gmail.com>,
mika.westerberg@linux.intel.com, ramakrishna.pallala@intel.com,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 4/9] dt-bindings: power: supply: Add device-tree binding for Summit SMB3xx
Date: Fri, 10 Apr 2020 22:02:35 +0300 [thread overview]
Message-ID: <8c4ab1ce-1947-ab38-3f8c-9055406428e4@gmail.com> (raw)
In-Reply-To: <20200410164905.GA719@bogus>
10.04.2020 19:49, Rob Herring пишет:
...
>> + summit,max-chg-curr:
>> + description: Maximum current for charging (in uA)
>> + allOf:
>> + - $ref: /schemas/types.yaml#/definitions/uint32
>> +
>> + summit,max-chg-volt:
>> + description: Maximum voltage for charging (in uV)
>> + allOf:
>> + - $ref: /schemas/types.yaml#/definitions/uint32
>> + minimum: 3500000
>> + maximum: 4500000
>> +
>> + summit,pre-chg-curr:
>> + description: Pre-charging current for charging (in uA)
>> + allOf:
>> + - $ref: /schemas/types.yaml#/definitions/uint32
>> +
>> + summit,term-curr:
>> + description: Charging cycle termination current (in uA)
>> + allOf:
>> + - $ref: /schemas/types.yaml#/definitions/uint32
...
> These are all properties of the battery attached and we have standard
> properties for some/all of these.
Looks like only four properties seem to be matching the properties of
the battery.txt binding.
Are you suggesting that these matching properties should be renamed
after the properties in battery.txt?
> Also, any property with units should have a unit suffix as defined in
> property-units.txt. And with that, you don't need to define the type.
Indeed, thank you for the suggestion.
next prev parent reply other threads:[~2020-04-10 19:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-29 16:15 [PATCH 0/9] Summit SMB3xx driver & device-tree David Heidelberg
2020-03-29 16:15 ` [PATCH 1/9] power: supply: smb347-charger: IRQSTAT_D is volatile David Heidelberg
2020-05-10 16:28 ` Sebastian Reichel
2020-03-29 16:15 ` [PATCH 2/9] power: supply: smb347-charger: Add delay before getting IRQSTAT David Heidelberg
2020-05-10 16:28 ` Sebastian Reichel
2020-03-29 16:15 ` [PATCH 3/9] power: supply: smb347-charger: Use resource-managed API David Heidelberg
2020-05-10 16:33 ` Sebastian Reichel
2020-03-29 16:21 ` [PATCH 4/9] dt-bindings: power: supply: Add device-tree binding for Summit SMB3xx David Heidelberg
2020-04-10 16:49 ` Rob Herring
2020-04-10 19:02 ` Dmitry Osipenko [this message]
2020-04-15 14:27 ` Rob Herring
2020-04-15 15:30 ` Dmitry Osipenko
2020-05-09 1:14 ` Sebastian Reichel
2020-05-14 19:34 ` Dmitry Osipenko
2020-03-29 16:21 ` [PATCH 5/9] power: supply: smb347-charger: Implement device-tree support David Heidelberg
2020-03-31 0:25 ` Jonghwa Lee
2020-03-31 17:20 ` Dmitry Osipenko
2020-03-29 16:21 ` [PATCH 6/9] power: supply: smb347-charger: Support SMB345 and SMB358 David Heidelberg
2020-05-10 16:40 ` Sebastian Reichel
2020-03-29 16:21 ` [PATCH 7/9] power: supply: smb347-charger: Remove virtual smb347-battery David Heidelberg
2020-03-29 16:21 ` [PATCH 8/9] power: supply: smb347-charger: Replace mutex with IRQ disable/enable David Heidelberg
2020-03-29 16:21 ` [PATCH 9/9] arm: dts: qcom: apq8064-nexus7: Add smb345 charger node David Heidelberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c4ab1ce-1947-ab38-3f8c-9055406428e4@gmail.com \
--to=digetx@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=john.stultz@linaro.org \
--cc=jonghwa3.lee@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=myungjoo.ham@samsung.com \
--cc=ramakrishna.pallala@intel.com \
--cc=robh@kernel.org \
--cc=simhavcs@gmail.com \
--cc=sre@kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).