From: SF Markus Elfring <elfring@users.sourceforge.net> To: linux-clk@vger.kernel.org, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@codeaurora.org> Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org Subject: [PATCH 4/5] clk: mvebu: Adjust two checks for null pointers in kirkwood_fix_sscg_deviation() Date: Wed, 19 Apr 2017 21:56:21 +0200 [thread overview] Message-ID: <8c5bdefb-896b-cd96-7e69-77ccb4a9286e@users.sourceforge.net> (raw) In-Reply-To: <8af5ccb0-f7c1-297c-2661-8ced61302c37@users.sourceforge.net> From: Markus Elfring <elfring@users.sourceforge.net> Date: Wed, 19 Apr 2017 21:17:19 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus fix the affected source code places. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/clk/mvebu/common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/mvebu/common.c b/drivers/clk/mvebu/common.c index 472c88b90256..659d534a137b 100644 --- a/drivers/clk/mvebu/common.c +++ b/drivers/clk/mvebu/common.c @@ -51,13 +51,13 @@ u32 kirkwood_fix_sscg_deviation(u32 system_clk) u64 freq_swing_half; sscg_np = of_find_node_by_name(NULL, "sscg"); - if (sscg_np == NULL) { + if (!sscg_np) { pr_err("cannot get SSCG register node\n"); return system_clk; } sscg_map = of_iomap(sscg_np, 0); - if (sscg_map == NULL) { + if (!sscg_map) { pr_err("cannot map SSCG register\n"); goto out; } -- 2.12.2
next prev parent reply other threads:[~2017-04-19 19:56 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-19 19:51 [PATCH 0/5] clk-mvebu: Fine-tuning for four function implementations SF Markus Elfring 2017-04-19 19:52 ` [PATCH 1/5] clk: mvebu: Use kcalloc() in of_cpu_clk_setup() SF Markus Elfring 2017-04-22 2:49 ` Stephen Boyd 2017-04-19 19:54 ` [PATCH 2/5] clk: mvebu: Adjust two checks for null pointers " SF Markus Elfring 2017-04-19 19:55 ` [PATCH 3/5] clk: mvebu: Use kcalloc() in two functions SF Markus Elfring 2017-04-22 2:49 ` Stephen Boyd 2017-04-19 19:56 ` SF Markus Elfring [this message] 2017-04-19 19:57 ` [PATCH 5/5] clk: mvebu: Delete an unnecessary variable initialisation in kirkwood_fix_sscg_deviation() SF Markus Elfring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8c5bdefb-896b-cd96-7e69-77ccb4a9286e@users.sourceforge.net \ --to=elfring@users.sourceforge.net \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mturquette@baylibre.com \ --cc=sboyd@codeaurora.org \ --subject='Re: [PATCH 4/5] clk: mvebu: Adjust two checks for null pointers in kirkwood_fix_sscg_deviation()' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).