linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Andrew Jeffery" <andrew@aj.id.au>
To: "George Liu" <liuxiwei1013@gmail.com>, linux-aspeed@lists.ozlabs.org
Cc: devicetree@vger.kernel.org, openbmc@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
	"George Liu" <liuxiwei@inspur.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1] ARM: dts: fp5280g2: Add KCS node for LPC MCTP
Date: Thu, 01 Jul 2021 13:36:37 +0930	[thread overview]
Message-ID: <8c808410-6444-46a3-8779-29ba1453a5ca@www.fastmail.com> (raw)
In-Reply-To: <20210625074031.32576-1-liuxiwei@inspur.com>

Hi George,

On Fri, 25 Jun 2021, at 17:10, George Liu wrote:
> Signed-off-by: George Liu <liuxiwei@inspur.com>
> ---
>  arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts 
> b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
> index 1752f3250e44..66c0542b2694 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
> @@ -300,6 +300,11 @@ &lpc_ctrl {
>  	flash = <&spi1>;
>  };
>  
> +&kcs4 {
> +	compatible = "openbmc,mctp-lpc";
> +	status = "okay";
> +};

This was a gross hack that we carried for a bit, it never went or was 
intended to go upstream. Please just use the standard KCS bindings.

Cheers,

Andrew

      reply	other threads:[~2021-07-01  4:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-25  7:40 [PATCH v1] ARM: dts: fp5280g2: Add KCS node for LPC MCTP George Liu
2021-07-01  4:06 ` Andrew Jeffery [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8c808410-6444-46a3-8779-29ba1453a5ca@www.fastmail.com \
    --to=andrew@aj.id.au \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liuxiwei1013@gmail.com \
    --cc=liuxiwei@inspur.com \
    --cc=openbmc@lists.ozlabs.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).