From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23A46C433DF for ; Thu, 4 Jun 2020 17:55:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC6DB207F7 for ; Thu, 4 Jun 2020 17:55:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="SLpT8Yn9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730355AbgFDRzf (ORCPT ); Thu, 4 Jun 2020 13:55:35 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:27356 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730361AbgFDRzd (ORCPT ); Thu, 4 Jun 2020 13:55:33 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1591293332; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=cGUSPwlMUHRfiWfesyQZg293NYiUtljPfBJhJ+fEDbI=; b=SLpT8Yn9wqhZWVOFdQABd5y21npcljBdlO8+yI0wbW2EZhZiK30R4YvzIjcKkXSXAXyAfqxL ndaC3gibUY6uw73ZKepaJY0aalLMEzydDgrZt6NtcRJ2eYYO3u8d9PXIMceDK9fTFBK456pO 8gupXmBVEyPkZYFu4/OYhrwwILQ= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-east-1.postgun.com with SMTP id 5ed93586cb04586933c78aa6 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 04 Jun 2020 17:55:18 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 239A4C433A0; Thu, 4 Jun 2020 17:55:17 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: sibis) by smtp.codeaurora.org (Postfix) with ESMTPSA id 4A102C433CA; Thu, 4 Jun 2020 17:55:16 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 04 Jun 2020 23:25:16 +0530 From: Sibi Sankar To: ppvk@codeaurora.org Cc: bjorn.andersson@linaro.org, adrian.hunter@intel.com, robh+dt@kernel.org, ulf.hansson@linaro.org, vbadigan@codeaurora.org, sboyd@kernel.org, georgi.djakov@linaro.org, mka@chromium.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-mmc-owner@vger.kernel.org, rnayak@codeaurora.org, matthias@chromium.org, linux-arm-msm-owner@vger.kernel.org, linux-kernel-owner@vger.kernel.org Subject: Re: [PATCH V1 1/2] mmc: sdhci-msm: Add interconnect bandwidth scaling support In-Reply-To: <8865e3b00fce4f28264b60cd498fcf02@codeaurora.org> References: <1591175376-2374-1-git-send-email-ppvk@codeaurora.org> <1591175376-2374-2-git-send-email-ppvk@codeaurora.org> <29826613b412e4f4db4289e292a1fe57@codeaurora.org> <8865e3b00fce4f28264b60cd498fcf02@codeaurora.org> Message-ID: <8cb639bf099b02ee4db271b28b49367f@codeaurora.org> X-Sender: sibis@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-06-04 16:43, ppvk@codeaurora.org wrote: > Hi Sibi, > > Thanks for the review!! > > On 2020-06-03 17:22, Sibi Sankar wrote: >> Hey Pradeep, >> Thanks for the patch. >> >> On 2020-06-03 14:39, Pradeep P V K wrote: >>> Interconnect bandwidth scaling support is now added as a >>> part of OPP [1]. So, make sure interconnect driver is ready >>> before handling interconnect scaling. >>> >>> This change is based on >>> [1] [Patch v8] Introduce OPP bandwidth bindings >>> (https://lkml.org/lkml/2020/5/12/493) >>> >>> [2] [Patch v3] mmc: sdhci-msm: Fix error handling >>> for dev_pm_opp_of_add_table() >>> (https://lkml.org/lkml/2020/5/5/491) >>> >>> Signed-off-by: Pradeep P V K >>> --- >>> drivers/mmc/host/sdhci-msm.c | 16 ++++++++++++++++ >>> 1 file changed, 16 insertions(+) >>> >>> diff --git a/drivers/mmc/host/sdhci-msm.c >>> b/drivers/mmc/host/sdhci-msm.c >>> index b277dd7..bf95484 100644 >>> --- a/drivers/mmc/host/sdhci-msm.c >>> +++ b/drivers/mmc/host/sdhci-msm.c >>> @@ -14,6 +14,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> >>> #include "sdhci-pltfm.h" >>> #include "cqhci.h" >>> @@ -1999,6 +2000,7 @@ static int sdhci_msm_probe(struct >>> platform_device *pdev) >>> struct sdhci_pltfm_host *pltfm_host; >>> struct sdhci_msm_host *msm_host; >>> struct clk *clk; >>> + struct icc_path *sdhc_path; >>> int ret; >>> u16 host_version, core_minor; >>> u32 core_version, config; >>> @@ -2070,6 +2072,20 @@ static int sdhci_msm_probe(struct >>> platform_device *pdev) >>> } >>> msm_host->bulk_clks[0].clk = clk; >>> >>> + /* Make sure that ICC driver is ready for interconnect bandwdith >>> + * scaling before registering the device for OPP. >>> + */ >>> + sdhc_path = of_icc_get(&pdev->dev, NULL); >>> + ret = PTR_ERR_OR_ZERO(sdhc_path); >>> + if (ret) { >>> + if (ret == -EPROBE_DEFER) >>> + dev_info(&pdev->dev, "defer icc path: %d\n", ret); >>> + else >>> + dev_err(&pdev->dev, "failed to get icc path:%d\n", ret); >>> + goto bus_clk_disable; >>> + } >>> + icc_put(sdhc_path); >> >> ret = dev_pm_opp_of_find_icc_paths(&pdev->dev, NULL); >> >> since there are multiple paths >> described in the bindings you >> should use ^^ instead and you >> can drop temporary path as well. >> > Ok. of_icc_get() used above is only to test if ICC driver is ready or > not. I'm not > really using the multiple paths here. Anyhow i will use > dev_pm_opp_of_find_icc_paths() > to get rid of some extra lines of code. Using dev_pm_opp_of_find_icc_paths with NULL passed acts as a way of validating all the paths specified in the device and also validates if the opp-table has bw related bindings as well. > >>> + >>> msm_host->opp_table = dev_pm_opp_set_clkname(&pdev->dev, "core"); >>> if (IS_ERR(msm_host->opp_table)) { >>> ret = PTR_ERR(msm_host->opp_table); -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.