From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Fabio Estevam <festevam@gmail.com>
Cc: Abel Vesa <abelvesa@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH] clk: imx8mp: register driver at arch_initcall time
Date: Mon, 21 Nov 2022 10:44:22 +0100 [thread overview]
Message-ID: <8cce4dae-c653-515b-1a5d-024986afbabf@rasmusvillemoes.dk> (raw)
In-Reply-To: <CAOMZO5AXSSkHpeuHNRQ6qkFoe2uiFLVxndz1u7_y7s9cLD9ppw@mail.gmail.com>
On 19/11/2022 23.02, Fabio Estevam wrote:
> On Sat, Nov 19, 2022 at 6:57 PM Rasmus Villemoes
> <linux@rasmusvillemoes.dk> wrote:
>
>> Sorry, I don't follow. Before this patch, the driver also implicitly had
>> a module_exit() doing exactly this platform_driver_unregister(), it was
>> just hidden inside the module_platform_driver() macro. And I think
>> that's necessary if one wants to test that the module can be loaded and
>> unloaded (I don't think it's ever useful or even possible to have it be
>> a module on an actual imx8mp board).
>
> You cannot load/unload it due to .suppress_bind_attrs = true, being passed.
That doesn't seem to be true. To test, I just built the imx8mq clk
driver as a module, and I could certainly both load and unload that on
my imx8mp platform. Sure, no "bind" attribute shows up in the
/sys/bus/platform/drivers/imx8mq-ccm/ directory, which is exactly what
one expects, but the module can be loaded just fine. And since it can be
loaded, it should also have a proper __exit call for deregistering the
driver on unload.
Rasmus
next prev parent reply other threads:[~2022-11-21 9:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 12:41 [PATCH] clk: imx8mp: register driver at arch_initcall time Rasmus Villemoes
2022-10-24 13:48 ` Rasmus Villemoes
2022-10-24 14:00 ` Ahmad Fatoum
2022-10-24 14:31 ` Rasmus Villemoes
2022-10-27 23:29 ` Stephen Boyd
2022-10-31 9:15 ` Rasmus Villemoes
2022-11-07 13:54 ` Rasmus Villemoes
2022-11-19 20:45 ` Rasmus Villemoes
2022-11-19 21:38 ` Fabio Estevam
2022-11-19 21:57 ` Rasmus Villemoes
2022-11-19 22:02 ` Fabio Estevam
2022-11-21 9:44 ` Rasmus Villemoes [this message]
2022-11-21 10:59 ` Fabio Estevam
2022-11-21 12:29 ` Rasmus Villemoes
2022-11-21 12:48 ` Fabio Estevam
2022-11-21 15:43 ` Abel Vesa
2022-11-22 7:49 ` Rasmus Villemoes
2022-11-23 1:42 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cce4dae-c653-515b-1a5d-024986afbabf@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=abelvesa@kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).