From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93633C07E99 for ; Mon, 12 Jul 2021 10:27:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B70061004 for ; Mon, 12 Jul 2021 10:27:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233864AbhGLK3u (ORCPT ); Mon, 12 Jul 2021 06:29:50 -0400 Received: from foss.arm.com ([217.140.110.172]:53148 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232768AbhGLK3n (ORCPT ); Mon, 12 Jul 2021 06:29:43 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 528A31FB; Mon, 12 Jul 2021 03:26:55 -0700 (PDT) Received: from [10.57.35.32] (unknown [10.57.35.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2FE183F694; Mon, 12 Jul 2021 03:26:54 -0700 (PDT) Subject: Re: [PATCH 2/2] coresight: catu: Correct memory sync ranges in catu mode To: Leo Yan , Mathieu Poirier , Mike Leach , Alexander Shishkin , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210710070206.462875-1-leo.yan@linaro.org> <20210710070206.462875-2-leo.yan@linaro.org> From: Suzuki K Poulose Message-ID: <8cdca2d5-5759-b3fd-be69-a596be384c2c@arm.com> Date: Mon, 12 Jul 2021 11:26:52 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210710070206.462875-2-leo.yan@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Leo, On 10/07/2021 08:02, Leo Yan wrote: > Current code misses to handle the case for the trace wrapping around, > thus it fails to sync the complete memory ranges in catu mode. > Similar to the tmc-sg, the infrastructure take care of wrapping the page indices to sync the correct memory. Suzuki > This patch corrects the memory sync ranges, when detects the wrapping > around case, it splits into two chunks: one chunk is the tail of the > buffer and another chunk is from the start of the buffer after wrapping > around. > > Signed-off-by: Leo Yan > --- > drivers/hwtracing/coresight/coresight-catu.c | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-catu.c b/drivers/hwtracing/coresight/coresight-catu.c > index e0740c6dbd54..634af451f0d3 100644 > --- a/drivers/hwtracing/coresight/coresight-catu.c > +++ b/drivers/hwtracing/coresight/coresight-catu.c > @@ -323,7 +323,24 @@ static void catu_sync_etr_buf(struct etr_buf *etr_buf, u64 rrp, u64 rwp) > } > > etr_buf->offset = r_offset; > - tmc_sg_table_sync_data_range(catu_table, r_offset, etr_buf->len); > + > + if (r_offset + etr_buf->len > etr_buf->size) { > + int len1, len2; > + > + /* > + * If trace data is wrapped around, sync AUX bounce buffer > + * for two chunks: "len1" is for the trace date length at > + * the tail of bounce buffer, and "len2" is the length from > + * the start of the buffer after wrapping around. > + */ > + len1 = etr_buf->size - r_offset; > + len2 = etr_buf->len - len1; > + tmc_sg_table_sync_data_range(catu_table, r_offset, len1); > + tmc_sg_table_sync_data_range(catu_table, 0, len2); > + } else { > + tmc_sg_table_sync_data_range(catu_table, r_offset, > + etr_buf->len); > + } > } > > static int catu_alloc_etr_buf(struct tmc_drvdata *tmc_drvdata, >