From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61F4D762C1; Wed, 21 Feb 2024 13:25:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708521932; cv=none; b=c3zhOI5onkEJB06GrkE5h/wOfV1ykG4A0oID8H70Lhf1jqXeL84dXxSrKLwbhH4QzVlE03pRIqU566Loi1OcAWOr7nwZrRfHlMt9qp09s7BpwZDxmNPXihgSzUyEkua4Y19+nPnDPuDFlGmLm9xKLvdYV/xWBM+YrIPP2HdgFbs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708521932; c=relaxed/simple; bh=Awv2ya/dCmyXIz+PUwM1HeJ90+1RVeiqxObGWE0hzLY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=b/YKcn8fD7cpaVmMd2hedUF7LL4ydXYgl6zeVzUqNHYUQl9xDO+4gEpdIythX9PA51lpIx8+vZssTbtro/1OgIgqx/V0JOd/pSHgg/hAsk1gf8oWq/71VqbyW74oI/Qt70VzPA7DKHIwhMsmVAL9OM8tOyiKWH1w1bEY9YK9ISA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y1LvHDmD; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y1LvHDmD" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-2997a9f4d61so2615130a91.3; Wed, 21 Feb 2024 05:25:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708521929; x=1709126729; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=OI7tqbj6mWKb61MysMY2DivYivNGwAjWTxPQEZuJVHY=; b=Y1LvHDmD+j9EJUHYcVk/3g7FWLgNLMLl8nz+xHgs18O9Be0EngqZsn3/XrOvN0EBOb 5Qyj3WntFZPlRmW1CcjsccFJguyw5u2lcF/WaV2GnRxu8hndChR/a0+EjGbmoJrsvZmd fEWOEb+Oa5+J0jBA3EV91bVZZXQkxGnHFjUQJ0XzyMputWn0rJeptGVP60S6ndZwy6vY 0/Pl4neVEHTVqwhS2hnQTIRuftU+BdoLYqVmfp9NVKVj9W3snL/Q/C+1xgcNU0qFB5o/ KWzJ++546+pSZ2rEwdCWVZLnqI6ZSowWJewRKnCYr4cuKUOQyPPbZAmbz9PS6vstJDWw BbFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708521929; x=1709126729; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OI7tqbj6mWKb61MysMY2DivYivNGwAjWTxPQEZuJVHY=; b=CHlFagmO5Xtst1d6lN3IzEmx2axZbkKifysUDAS1ViKtk8En7AIH0HUDZ+ncz51Pit itp35h3Tvykou1kTVL+FM6yc2lWcW9bqm8kSPLDvjDavoc4aXovYFj6TEbwvIZfVJPlN KVXJBfajOntaQ9s7TCneAU312uSNfAUDsapuVtjUlD7YOjtSZfOl9+YY1zTBBtSC6k/3 cc3E9Y0qQZr8L9oyNupZ/3V+lfMVHpaR/6r6FukcE85EHEd7mg+TTgwYZBKPtDV4y8rb Mac7cAcZOb/9yUL4AaW98tkPstPRUx+KkGpAUOuaA3wdz+iJQTqfBJHCD0oSLtCz6NVG 9D/A== X-Forwarded-Encrypted: i=1; AJvYcCVKlZ170aEBx72/zlaq6hL/y3MbzJileHXEFIIgM6ivrHTl8OmlP5aUTL7f3+K+x+LnpiTyVTVy9zuqVQV93qav90+psSWDg8V0uVhkD713SCjHGQQPprVlODYV55dxcJbYdQIT1k/xtjyBAKwVxyXILqyQ9/+bbXhRVVPsLWF79U7bkBpwcoVPBSIF6LW/wvS0ixQvs+4eXPsoqVjrEIdHPbxJuNztMi6/Vyg+TRiA0TVOY0HR9RwcpRR9QjdYU4Qh X-Gm-Message-State: AOJu0YwjQjenJThJJzPA7SF1BlqBuy1gmuqV2NKvkDOIsBHqQPtU1btl fEltS9y+4FPnMljIvemibqO60VyAfXsFEkNbL643e8QSoM0njbIk X-Google-Smtp-Source: AGHT+IHg9MoLpqgIlSHX+Evp1yAd6u93J1yLlc8YUipHUrY6efz32qYsKutsv5edzLysx+zDmmo/rg== X-Received: by 2002:a17:90a:dd82:b0:299:5186:1989 with SMTP id l2-20020a17090add8200b0029951861989mr10159029pjv.37.1708521929579; Wed, 21 Feb 2024 05:25:29 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id ds15-20020a17090b08cf00b002992cf08af0sm1359109pjb.23.2024.02.21.05.25.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 05:25:28 -0800 (PST) Sender: Guenter Roeck Date: Wed, 21 Feb 2024 05:25:27 -0800 From: Guenter Roeck To: David Gow Cc: Linus Torvalds , Shuah Khan , Rae Moar , Matthew Auld , Arunpravin Paneer Selvam , Christian =?iso-8859-1?Q?K=F6nig?= , Kees Cook , =?iso-8859-1?Q?Ma=EDra?= Canal , Rodrigo Vivi , Matthew Brost , Willem de Bruijn , Florian Westphal , Cassio Neri , Javier Martinez Canillas , Arthur Grillo , Brendan Higgins , Daniel Latypov , Stephen Boyd , David Airlie , Maxime Ripard , "David S . Miller" , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org, linux-rtc@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-hardening@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 1/9] kunit: test: Log the correct filter string in executor_test Message-ID: <8cfc6a3e-e618-4ddd-adca-4d6bf81a5e17@roeck-us.net> References: <20240221092728.1281499-1-davidgow@google.com> <20240221092728.1281499-2-davidgow@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240221092728.1281499-2-davidgow@google.com> On Wed, Feb 21, 2024 at 05:27:14PM +0800, David Gow wrote: > KUnit's executor_test logs the filter string in KUNIT_ASSERT_EQ_MSG(), > but passed a random character from the filter, rather than the whole > string. > > This was found by annotating KUNIT_ASSERT_EQ_MSG() to let gcc validate > the format string. > > Fixes: 76066f93f1df ("kunit: add tests for filtering attributes") > Signed-off-by: David Gow Tested-by: Guenter Roeck > --- > lib/kunit/executor_test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/kunit/executor_test.c b/lib/kunit/executor_test.c > index 22d4ee86dbed..3f7f967e3688 100644 > --- a/lib/kunit/executor_test.c > +++ b/lib/kunit/executor_test.c > @@ -129,7 +129,7 @@ static void parse_filter_attr_test(struct kunit *test) > GFP_KERNEL); > for (j = 0; j < filter_count; j++) { > parsed_filters[j] = kunit_next_attr_filter(&filter, &err); > - KUNIT_ASSERT_EQ_MSG(test, err, 0, "failed to parse filter '%s'", filters[j]); > + KUNIT_ASSERT_EQ_MSG(test, err, 0, "failed to parse filter from '%s'", filters); > } > > KUNIT_EXPECT_STREQ(test, kunit_attr_filter_name(parsed_filters[0]), "speed"); > -- > 2.44.0.rc0.258.g7320e95886-goog >