From: Randy Dunlap <rdunlap@infradead.org>
To: mgross@linux.intel.com, markgross@kernel.org, arnd@arndb.de,
bp@suse.de, damien.lemoal@wdc.com, dragan.cvetic@xilinx.com,
gregkh@linuxfoundation.org, corbet@lwn.net,
palmerdabbelt@google.com, paul.walmsley@sifive.com,
peng.fan@nxp.com, robh+dt@kernel.org, shawnguo@kernel.org,
jassisinghbrar@gmail.com
Cc: linux-kernel@vger.kernel.org,
Ramya P Karanth <ramya.p.karanth@intel.com>
Subject: Re: [PATCH v3 31/34] Intel Keem Bay XLink SMBus driver
Date: Tue, 26 Jan 2021 20:29:39 -0800 [thread overview]
Message-ID: <8d0cc185-8e0c-f0a4-dc9c-b0040083254f@infradead.org> (raw)
In-Reply-To: <20210126054036.61587-32-mgross@linux.intel.com>
On 1/25/21 9:40 PM, mgross@linux.intel.com wrote:
> diff --git a/drivers/misc/xlink-smbus/Kconfig b/drivers/misc/xlink-smbus/Kconfig
> new file mode 100644
> index 000000000000..e6cdf8b9a096
> --- /dev/null
> +++ b/drivers/misc/xlink-smbus/Kconfig
> @@ -0,0 +1,26 @@
> +# Copyright (C) 2020 Intel Corporation
> +# SPDX-License-Identifier: GPL-2.0-only
> +
> +config XLINK_SMBUS
> + tristate "Enable smbus interface over Xlink PCIe"
s/smbus/SMBUS/
as in the other config below.
> + depends on XLINK_CORE
> + depends on HDDL_DEVICE_CLIENT || HDDL_DEVICE_SERVER
> + help
> + Enable xlink-pcie as i2c adapter both slave and master. The server
s/i2c/I2C/
> + (Remote Host) will use this interface to get sensor data from the soc
s/soc/SOC/ or maybe SoC
> + (vision accelerator - Local Host) which is connected over PCIe.
> + This driver is loaded on both Remote Host and Local Host.
> + Select M to compile the driver as a module, name is xlink-smbus.
> + If unsure, select N.
and all of that help text should be indented with one tab + 2 spaces.
> +
> +
> +config XLINK_SMBUS_PROXY
> + tristate "Enable SMBUS adapter as proxy for I2C controller"
> + depends on XLINK_CORE
> + depends on XLINK_SMBUS
> + help
> + Enable this config when SMBUS adapter is acting as proxy for
> + another I2C controller.
> + Select M or Y if building for Intel Vision Processing Unit (VPU)
> + Local Host core.
> + Select N, if building for a Remote Host kernel.
All of that help text should be indented with one tab + 2 spaces.
--
~Randy
netiquette: https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2021-01-27 5:11 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 5:40 [PATCH v3 00/34] Intel Vision Processing base enabling mgross
2021-01-26 5:40 ` [PATCH v3 01/34] Add Vision Processing Unit (VPU) documentation mgross
2021-01-26 5:40 ` [PATCH v3 02/34] dt-bindings: mailbox: Add Intel VPU IPC mailbox bindings mgross
2021-01-26 13:44 ` Rob Herring
2021-01-26 14:47 ` Gross, Mark
2021-01-28 21:42 ` mark gross
2021-01-26 5:40 ` [PATCH v3 03/34] mailbox: vpu-ipc-mailbox: Add support for Intel VPU IPC mailbox mgross
2021-01-26 5:40 ` [PATCH v3 04/34] dt-bindings: Add bindings for Keem Bay IPC driver mgross
2021-01-26 5:40 ` [PATCH v3 05/34] keembay-ipc: Add Keem Bay IPC module mgross
2021-01-26 5:40 ` [PATCH v3 06/34] dt-bindings: Add bindings for Keem Bay VPU IPC driver mgross
2021-01-27 14:00 ` Rob Herring
2021-01-30 2:02 ` mark gross
2021-01-26 5:40 ` [PATCH v3 07/34] keembay-vpu-ipc: Add Keem Bay VPU IPC module mgross
2021-01-26 5:40 ` [PATCH v3 08/34] misc: xlink-pcie: Add documentation for XLink PCIe driver mgross
2021-01-26 5:40 ` [PATCH v3 09/34] misc: xlink-pcie: lh: Add PCIe EPF driver for Local Host mgross
2021-01-26 5:40 ` [PATCH v3 10/34] misc: xlink-pcie: lh: Add PCIe EP DMA functionality mgross
2021-01-26 5:40 ` [PATCH v3 11/34] misc: xlink-pcie: lh: Add core communication logic mgross
2021-01-26 5:40 ` [PATCH v3 12/34] misc: xlink-pcie: lh: Prepare changes for adding remote host driver mgross
2021-01-26 5:40 ` [PATCH v3 13/34] misc: xlink-pcie: rh: Add PCIe EP driver for Remote Host mgross
2021-01-26 5:40 ` [PATCH v3 14/34] misc: xlink-pcie: rh: Add core communication logic mgross
2021-01-26 5:40 ` [PATCH v3 15/34] misc: xlink-pcie: Add XLink API interface mgross
2021-01-26 5:40 ` [PATCH v3 16/34] misc: xlink-pcie: Add asynchronous event notification support for XLink mgross
2021-01-26 5:40 ` [PATCH v3 17/34] xlink-ipc: Add xlink ipc device tree bindings mgross
2021-01-27 14:00 ` Rob Herring
2021-01-26 5:40 ` [PATCH v3 18/34] xlink-ipc: Add xlink ipc driver mgross
2021-01-26 5:40 ` [PATCH v3 19/34] xlink-core: Add xlink core device tree bindings mgross
2021-01-27 14:00 ` Rob Herring
2021-01-26 5:40 ` [PATCH v3 20/34] xlink-core: Add xlink core driver xLink mgross
2021-01-26 5:40 ` [PATCH v3 21/34] xlink-core: Enable xlink protocol over pcie mgross
2021-01-26 5:40 ` [PATCH v3 22/34] xlink-core: Enable VPU IP management and runtime control mgross
2021-01-26 5:40 ` [PATCH v3 23/34] xlink-core: add async channel and events mgross
2021-01-26 5:40 ` [PATCH v3 24/34] dt-bindings: misc: Add Keem Bay vpumgr mgross
2021-01-26 5:40 ` [PATCH v3 25/34] misc: Add Keem Bay VPU manager mgross
2021-01-27 4:31 ` Randy Dunlap
2021-01-26 5:40 ` [PATCH v3 26/34] dt-bindings: misc: intel_tsens: Add tsens thermal bindings documentation mgross
2021-01-26 5:40 ` [PATCH v3 27/34] misc: Tsens ARM host thermal driver mgross
2021-01-26 5:40 ` [PATCH v3 28/34] misc: Intel tsens IA host driver mgross
2021-01-26 5:40 ` [PATCH v3 29/34] Intel tsens i2c slave driver mgross
2021-01-27 4:36 ` Randy Dunlap
2021-01-26 5:40 ` [PATCH v3 30/34] misc:intel_tsens: Intel Keem Bay tsens driver mgross
2021-01-26 5:40 ` [PATCH v3 31/34] Intel Keem Bay XLink SMBus driver mgross
2021-01-27 4:29 ` Randy Dunlap [this message]
2021-01-26 5:40 ` [PATCH v3 32/34] dt-bindings: misc: hddl_dev: Add hddl device management documentation mgross
2021-01-26 5:40 ` [PATCH v3 33/34] misc: Hddl device management for local host mgross
2021-01-27 4:34 ` Randy Dunlap
2021-01-26 5:40 ` [PATCH v3 34/34] misc: HDDL device management for IA host mgross
2021-01-27 4:26 ` Randy Dunlap
2021-01-30 2:20 [PATCH v3 00/34] Intel Vision Processing base enabling mgross
2021-01-30 2:20 ` [PATCH v3 31/34] Intel Keem Bay XLink SMBus driver mgross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d0cc185-8e0c-f0a4-dc9c-b0040083254f@infradead.org \
--to=rdunlap@infradead.org \
--cc=arnd@arndb.de \
--cc=bp@suse.de \
--cc=corbet@lwn.net \
--cc=damien.lemoal@wdc.com \
--cc=dragan.cvetic@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=jassisinghbrar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=mgross@linux.intel.com \
--cc=palmerdabbelt@google.com \
--cc=paul.walmsley@sifive.com \
--cc=peng.fan@nxp.com \
--cc=ramya.p.karanth@intel.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).