linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rantala, Tommi T. (Nokia - FI/Espoo)" <tommi.t.rantala@nokia.com>
To: "stable@vger.kernel.org" <stable@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: 4.14 revert "seccomp: add a selftest for get_metadata"
Date: Mon, 28 Jan 2019 17:13:11 +0000	[thread overview]
Message-ID: <8d246df3cdf19608cb6a043bf1dabe8f0adcae6d.camel@nokia.com> (raw)

Hi Greg,

Can you please revert this commit in 4.14?

commit e65cd9a20343ea90f576c24c38ee85ab6e7d5fec
Author: Tycho Andersen <tycho@tycho.ws>
Date:   Tue Feb 20 19:47:47 2018 -0700

    seccomp: add a selftest for get_metadata
    
    [ Upstream commit d057dc4e35e16050befa3dda943876dab39cbf80 ]
    
    Let's test that we get the flags correctly, and that we preserve
the filter
    index across the ptrace(PTRACE_SECCOMP_GET_METADATA) correctly.



PTRACE_SECCOMP_GET_METADATA was only added in 4.16
(26500475ac1b499d8636ff281311d633909f5d20)


And it's also breaking seccomp_bpf.c compilation for me:

seccomp_bpf.c: In function ‘get_metadata’:
seccomp_bpf.c:2878:26: error: storage size of ‘md’ isn’t known
  struct seccomp_metadata md;
                          ^~

-Tommi


             reply	other threads:[~2019-01-28 17:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-28 17:13 Rantala, Tommi T. (Nokia - FI/Espoo) [this message]
2019-01-28 17:22 ` 4.14 revert "seccomp: add a selftest for get_metadata" Tycho Andersen
2019-01-28 19:42 ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8d246df3cdf19608cb6a043bf1dabe8f0adcae6d.camel@nokia.com \
    --to=tommi.t.rantala@nokia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).