From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757402AbdELHc6 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 12 May 2017 03:32:58 -0400
Received: from mout.web.de ([212.227.15.3]:57332 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753208AbdELHc4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 12 May 2017 03:32:56 -0400
Subject: Re: vmbus: Delete an error message for a failed memory allocation in
 vmbus_device_create()
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
        Wolfram Sang <wsa@the-dreams.de>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        kernel-janitors@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
        devel@linuxdriverproject.org
References: <dea9c6a3-0ae6-f3fe-c0d3-7f5b856e2638@users.sourceforge.net>
 <587dbcf5-8b12-fac7-693e-5f471e6d5167@users.sourceforge.net>
 <20170511093015.4cdfdb6c@xeon-e3> <20170512070909.xxa62d2cde3qoj4f@mwanda>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <8d38547f-a086-438a-5b2a-4d11929530ec@users.sourceforge.net>
Date: Fri, 12 May 2017 09:32:39 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.0
MIME-Version: 1.0
In-Reply-To: <20170512070909.xxa62d2cde3qoj4f@mwanda>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:AXJvdUSft/KYdci5sWkMe6NHmtiGEdxsEXPE1XsJYPajqLkyubd
 E/8udivYEplvV3UEN34ZyYwX+36plOh+BnKcOQc9T0gUi7+VVl64HKapyIhwOglqbE06zmw
 fSFVUGVWB9BcPKhSxoRypCYVVdeMiZkoox2dnbdwJOrga2bjlcK+iOIlC5Liv477y+Glebz
 phcOnOIhuS9iEpleGhsaQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:MKCcjnxcMfM=:pDXj+7I5JtZuEWGL8zVhFu
 4zjxB7eCQ7/NOHGBaY+K2goBxkZSJFkAss9eqav69H3Er7Y6J/IM1Xm8DrIoK62H1mLZ/D5tn
 IqZFK9GQNcrNi1+EL614YREnW6PXXg7PYaT2tKtfv4635Nbj9EYR6AufqSSDQCIWRkGbRcVJM
 Skf7LI66gNyHAQwJNDIJWR564YwqZ9CeGIBcc9HOwGEN8T4p3F6SAJC6kEeuG/3c1owRKKlCK
 JmvlzBPsRY/3E8NvxZVjIG7lr3drsfWQg/Lja9DtrwxY1ZMNFDJZORaL6FgMTJg8gx7xGZ3bq
 vMBzxKbCXBucS0yqlrnzrGvLCa16LBup5fc3UGJVB38SBvAyIKUHkQFmpxbEMpaa4RP0c4IdE
 uAe0JfjsDjfCNywW4ozW2kWWF/lpZyAdZQh6A8Jzy7bKJYbs+ntz5f9CDj/fwojYInvmicI3t
 aI3qsJ7GiFwqyRzUCTxa5Ts+qjey0p8C5YJVWl+MMPVLpBGLHWFsAQMyihb2JJUA0/b/9a6ei
 aar/9UW3I3oB3wxAaLIIDdZt4QIfSaSdvGZFbo8W0o9LG0rmIEwOOJ13pUGUMCdj65oPTGQqs
 jtHsy47DEpOd7welrDbDwHr6oJlG7+7aS7pk0XThcUXJs1mVViGtyvWAYiAXtWaOCrnUN59MG
 dt2rPYXW4X0R6aRHNuKBkbJVSyr2Or/rVPWJATzSOcLbNGXwvKjjaINDc/Vm2wsiIlviRnoSp
 xGgBcP61C8LDkzlJ231i4qYDupUYjL3aD8upIdBHrnc3eBLywKubuUjg/tpbyfjcngQAArchC
 ih9dQ97
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> Just because an automated tool says that this needs to change does not
>> mean it has to.
> 
> Checkpatch.pl is correct here.  This message is useless.  It's during
> init so it's unlikely to fail ever.  In current kernels small kmallocs
> are quaranteed to succeed so it can't actually fail currently.  The
> stack trace is more useful than this message because it tells you a lot
> about what memory is free and the whole call tree.
> 
> The error message is dead useless code.

Would you like to clarify corresponding software evolution any more?

Is there a need for better documentation of the involved programming interfaces?


> This patch is not going to be merged because Markus doesn't listen to
> feedback and he's blocked but otherwise it's an OK patch.

Does this information contain a contradiction?
Will patches be picked up also from contributors who got a special
development reputation anyhow?

Regards,
Markus